Re: Porposing libgnomesu for 2.10

[Kjartan Maraas <kmaraas broadpark no>]

tor, 28,.10.2004 kl. 19.20 +0200, skrev Luca Ferretti:
> Il giorno gio, 28-10-2004 alle 12:37 +0200, Hongli Lai ha scritto:
> > I'm the maintainer of libgnomesu and I would like to propose it for 
> > inclusion in 2.10.
> > libgnomesu is a library which allows applications to run programs as 
> > another user or root. Think 'su' with graphical user interface. More 
> > info here: http://members1.chello.nl/~h.lai/libgnomesu/
> > It's in GNOME CVS, module libgnomesu. Also, Benoit Dejean, maintainer of 
> > GNOME System Monitor, is interested in using libgnomesu.
> 
> It could be useful for GNOME System Tool and GNOME Log viewer too.
> 
> And of course any application that needs to run with root privileges,
> such as distro configuration tools, so IMHO it's a good addition for the
> GNOME-is-a-platform prospective,
> 
> The pam backend is the RIGHT idea.
> 
> > I'm not sure if it should go into the desktop platform or developer 
> > platform. I'm thinking about desktop platform. Any comments/suggestions 
> > regarding this?
> 
> == String and UI == 
> 
> s/superuser/administrator (or whatever suggested by GNOME style guide)
> 
> Review dialog to make HIG-compliant:
>       * Use the GTK-DIALOG-AUTHENTICATION stock icon in dialogs, as
>         suggested in HIG -> Alerts
>       * Maybe change the Run button to OK
>       * remove the "verifying password" and use mouse_wait
> 
> == Bug fixing ==
> 
> Compilation fails on su-backend/su.c, Mandrake 10.1 Community, here the
> log
> 
> In file included from system.h:218,
>                  from su.c:68:
> sys2.h:139: error: conflicting types for 'malloc'
> sys2.h:139: error: conflicting types for 'malloc'
> sys2.h:143: error: conflicting types for 'memchr'
> /usr/include/string.h:66: error: previous declaration of 'memchr' was
> here
> sys2.h:143: error: conflicting types for 'memchr'
> /usr/include/string.h:66: error: previous declaration of 'memchr' was
> here
> sys2.h:147: error: conflicting types for 'realloc'
> /usr/include/stdlib.h:567: error: previous declaration of 'realloc' was
> here
> sys2.h:147: error: conflicting types for 'realloc'
> /usr/include/stdlib.h:567: error: previous declaration of 'realloc' was
> here
> make[1]: *** [su.o] Error 1
> make[1]: Leaving directory `/usr/src/GNOME/libgnomesu/su-backend'
> make: *** [install-recursive] Error 1
> 
I see this on FC3 too. Why are you redefining all these functions in
there? Shouldn't configure checks for these "Just work (TM)"?

Cheers
Kjartan