Re: tinderbox breakages in moz, soup, gnome-menus, libgnomeprint

[Elijah Newren <newren gmail com>]

On 8/14/05, Luis Villa <luis villa gmail com> wrote:
> On 8/14/05, Mark McLoughlin <markmc redhat com> wrote:

> >         Doesn't make any sense to me, really. The code looks fine and compiles
> > without any warnings or errors here ...
> >
> >         Can I see the full log?

<snip>

>  gcc -DHAVE_CONFIG_H -I. -I. -I.. -DGMENU_I_KNOW_THIS_IS_UNSTABLE
> -I/home/bb/microtinder/build-output/include/glib-2.0
> -I/home/bb/microtinder/build-output/lib/glib-2.0/include
> -DG_ENABLE_DEBUG -Wall -Wmissing-prototypes -g -O2 -MT menu-monitor.lo
> -MD -MP -MF .deps/menu-monitor.Tpo -c menu-monitor.c  -fPIC -DPIC -o
> .libs/menu-monitor.o
> make[2]: Leaving directory `/home/bb/microtinder/cvs/gnome-menus/libmenu'
> make[1]: Leaving directory `/home/bb/microtinder/cvs/gnome-menus'
> menu-monitor.c: In function 'menu_monitor_unref':
> menu-monitor.c:537: error: 'menu_monitor_notify_unref' undeclared
> (first use in this function)
> menu-monitor.c:537: error: (Each undeclared identifier is reported only once
> menu-monitor.c:537: error: for each function it appears in.)
> make[2]: *** [menu-monitor.lo] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2

I get the same thing here.  Seems to be due to the
menu_monitor_notify_unref declaration being surrounded by an #ifdef
HAVE_FAM while the code that tries to call that function is not
surrounded by any such #ifdef.  I have a simple patch that makes it
compile (attached); not sure if it's correct as I'm not sure whether
it's all supposed to be wrapped by an #ifdef or if none of it is.

- Elijah

? depcomp
? get-gnome-menus-to-compile.patch
? py-compile
Index: libmenu/menu-monitor.c
===================================================================
RCS file: /cvs/gnome/gnome-menus/libmenu/menu-monitor.c,v
retrieving revision 1.5
diff -p -u -r1.5 menu-monitor.c
--- libmenu/menu-monitor.c	12 Aug 2005 06:43:06 -0000	1.5
+++ libmenu/menu-monitor.c	14 Aug 2005 14:45:26 -0000
@@ -61,15 +61,15 @@ typedef struct
 
 static GHashTable *monitors_registry = NULL;
 
+static MenuMonitorNotify *menu_monitor_notify_ref   (MenuMonitorNotify *notify);
+static void               menu_monitor_notify_unref (MenuMonitorNotify *notify);
+
 #ifdef HAVE_FAM
 static FAMConnection  fam_connection;
 static gboolean       opened_connection = FALSE;
 static gboolean       failed_to_connect = FALSE;
 static guint          fam_io_watch = 0;
 static guint          events_idle_handler = 0;
-
-static MenuMonitorNotify *menu_monitor_notify_ref   (MenuMonitorNotify *notify);
-static void               menu_monitor_notify_unref (MenuMonitorNotify *notify);
 
 static void
 invoke_notifies (MenuMonitor      *monitor,