Re: removing non-working things



Hey Matthias,

On Sun, 2006-07-30 at 14:47 -0400, Matthias Clasen wrote:
> The gnome-ui-properties capplet contains a "Detachable toolbars"
> checkbox, which has three issues:
> 
> a) It only affects BonoboToolbars, not for regular GtkToolbars

Nod

> b) It does not even work correctly for bonobo toolbars (try
>    detaching and reattaching the evolution toolbar, for instance)

Wasn't that this bug?
http://bugzilla.gnome.org/show_bug.cgi?id=167944

If it doesn't work properly, it's a regression.
I backported this patch to a 2.8.x version of libbonoboui, and it seemed
to work fine.

> c) Even if it worked correctly everywhere, it is not a very
>    useful feature.

Not useful at all.

> So I'd like to propose that we drop this checkbox. 
> 
> If there is a need to fill the void, we could add a "Show icons in
> buttons" checkbox instead, since this is a feature that works reliably
> everywhere...

I'd kill it as well. Is there a bugzill opened already?

-- 
Bastien Nocera <hadess hadess net> 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]