Re: [Fwd: Re: gnome-media/gnome-cd commit]

["Michael Terry" <mike mterry name>]

Whoa, whoa, whoa.  I think there's some miscommunication here.

First and foremost, I will go about reverting tonight.

Secondly, I did reply to Bastien when he originally emailed me
explaining that I was under the impression I had gotten permission (in
bug 411975).  It appears I didn't include Ronald in that reply (a
Reply/Reply All mistake).  The text of my email is below [1].

I thought that the matter was resolved with that explanation because I
heard no response.  Ronald's email on the 9th never made it to me.  It
appears to only be addressed to Bastien(?).

Again, I'm sorry for the trouble this commit has caused, but I never
acted in bad faith.  I honestly originally thought permission had been
granted and never received notice to revert (did Ronald also email the
invalid mterry gnome org address?).

-mt

[1] "Hello, Bastien!

Mmm, I don't think Ronald did.  In bug #411975 [1], Marc-Andre Lureau
reviewed the patch and said it should be committed.  So I did.

If I messed up procedure, it was an accident.  Also sorry for the
misleading email account.  That was a misunderstanding on my part
(thought CVS access came with an email to use for CVS commits).

[1] http://bugzilla.gnome.org/show_bug.cgi?id=411975";


On 9/6/07, Bastien Nocera <hadess hadess net> wrote:
> FYI,
>
> Mike, you still haven't reverted this commit, despite having nearly a
> month to do so. The code in itself doesn't look like it's going to cause
> problems, but consider this your first warning.
>
> You need to ask maintainers permission before doing commits like this,
> especially as a new contributor (which I guess from your Bugzilla
> statistics).
>
> GNOME SVN isn't a free-for-all...
>
> Cheers
>
> --
> Bastien Nocera <hadess hadess net>
>
>
> ---------- Forwarded message ----------
> From: "Ronald S. Bultje" <rbultje ronald bitfreak net>
> To: "Bastien Nocera" <hadess hadess net>
> Date: Thu, 9 Aug 2007 23:54:32 -0700
> Subject: Re: gnome-media/gnome-cd commit
> I can't remember ok'ing this, Michael, please revert and put in bugzilla. If
> not, I will, and I'll be a pain to make it go in again. I promise.
>
> Ronald
>
>
> On 8/9/07, Bastien Nocera <hadess hadess net> wrote:
> > Hey Michael,
> >
> > I just wanted to know why you committed to gnome-cd[1] without
> > branching. Did Ronald give you the right to commit without branching?
> >
> > Cheers
> >
> > PS: The e-mail address you used for your commit log doesn't work either.
> >
> > [1]: The big commit:
> > 2007-05-14  Michael Terry  <mterry gnome org>
> >
> >        * Makefile.am: Install app icon into hicolor theme, not .../pixmaps
> >
> >        * gnome-cd.c: (make_button_from_icon_name), (make_popup_menu),
> >        (init_player), (tray_icon_create), (main): Look up icons in theme,
> >        not from stock
> >
> >        * gnome-cd.desktop.in.in: Remove png suffix from icon
> >
> >        * images/Makefile.am:
> >        * images/None/Makefile.am:
> >
> >        Don't install unused icons
> >
> >        * images/None/None.theme: Remove obsolete <icons> section
> >
> >        * images/media/media-fwd.png:
> >        * images/media/media-stop.png:
> >        * images/media/a-stop-menu.png:
> >        * images/media/media- eject.png:
> >        * images/media/a-first-menu.png:
> >        * images/media/a-eject-menu.png:
> >        * images/media/media-rew.png:
> >        * images/media/media-play.png:
> >        * images/media/a-last-menu.png:
> >        * images/media/a-play-menu.png:
> >        * images/media/media-rec.png:
> >        * images/media/media-prev.png:
> >        * images/media/media-pause.png:
> >        * images/media/media-next.png:
> >        * images/media- eject.png:
> >        * images/None/media-fwd.png:
> >        * images/None/media-stop.png:
> >        * images/None/a-stop-menu.png:
> >        * images/None/a-first-menu.png:
> >        * images/None/media-eject.png:
> >        * images/None/media- rew.png:
> >        * images/None/a-eject-menu.png:
> >        * images/None/media-play.png:
> >        * images/None/a-last-menu.png:
> >        * images/None/a-play-menu.png:
> >        * images/None/media-prev.png:
> >        * images/None/media- pause.png:
> >        * images/None/media-next.png:
> >        * images/lcd/a-fwd.png:
> >        * images/lcd/a-pause-pressed.png:
> >        * images/lcd/a-fwd-pressed.png:
> >        * images/lcd/a-first.png:
> >        * images/lcd/a- first-menu.png:
> >        * images/lcd/a-eject.png:
> >        * images/lcd/a-first-pressed.png:
> >        * images/lcd/a-eject-pressed.png:
> >        * images/lcd/a-rwnd.png:
> >        * images/lcd/a-rwnd-pressed.png:
> >        * images/lcd/a-stop.png:
> >        * images/lcd/a-stop-menu.png:
> >        * images/lcd/a-stop-pressed.png:
> >        * images/lcd/a-eject-menu.png:
> >        * images/lcd/a-last.png:
> >        * images/lcd/a-last-menu.png :
> >        * images/lcd/a-play.png:
> >        * images/lcd/a-last-pressed.png:
> >        * images/lcd/a-play-menu.png:
> >        * images/lcd/a-play-pressed.png:
> >        * images/lcd/a-pause.png:
> >        * images/mixer.png:
> >        * images/a-play-menu.png:
> >        * images/cd.png:
> >        * images/red-lcd/a-fwd.png:
> >        * images/red-lcd/a-pause-pressed.png:
> >        * images/red-lcd/a-fwd-pressed.png:
> >        * images/red-lcd/a- first.png:
> >        * images/red-lcd/a-first-menu.png:
> >        * images/red-lcd/a-eject.png:
> >        * images/red-lcd/a-first-pressed.png:
> >        * images/red-lcd/a-eject-pressed.png:
> >        * images/red-lcd/a- rwnd.png:
> >        * images/red-lcd/a-rwnd-pressed.png:
> >        * images/red-lcd/a-stop.png:
> >        * images/red-lcd/a-stop-menu.png:
> >        * images/red-lcd/a-stop-pressed.png:
> >        * images/red-lcd/a-eject-menu.png :
> >        * images/red-lcd/a-last.png:
> >        * images/red-lcd/a-last-menu.png:
> >        * images/red-lcd/a-play.png:
> >        * images/red-lcd/a-last-pressed.png:
> >        * images/red-lcd/a-play-menu.png:
> >        * images/red-lcd/a- play-pressed.png:
> >        * images/red-lcd/a-pause.png:
> >
> >        Deleted, as these icons are unused or grabbed from icon theme
> >        instead
> > --
> > Bastien Nocera <hadess hadess net >
> >
> >
>
>
>