Re: Commit auto-links in bugzilla comments

[Xavier Claessens <xclaesse gmail com>]

Le mercredi 11 février 2015 à 09:52 -0800, Jasper St. Pierre a écrit :
> Out of curiosity, is there anything wrong with just copy/pasting a
> link? You know, something like
>
> https://git.gnome.org/browse/gnome-shell/commit/?id=d54b87c4559bd9d74fa10d3e3d1e38a933bea051

There is nothing wrong with copy/pasting the link, but then you have to
browse git.gnome.org to find the commit/branch link. The nice thing with
letting bugzilla build the link is that all you need to know is the
commit hash or branch name, and that info is in your terminal.

> I find that trying to remember crazy syntax and exceptions is a bit
> difficult. Does it work inside parens with immediate closing like
> "(see also comment #13)"? Does it work with and without the number
> sign? After a line-break, one like Bugzilla likes to auto-add? I've
> ran into so many exceptions it's hard to remember what's valid.

It's indeed hidden secret, and the regex isn't always perfect the first
time. Nobody is forced to use it, but IMO it's nice little trick that
doesn't cost us much, does it? 

> On Wed, Feb 11, 2015 at 9:43 AM, Xavier Claessens <xclaesse gmail com>
> wrote:
>         Le mardi 10 février 2015 à 08:38 +0100, Milan Crha a écrit :
>         >         Hello,
>         > I'd like to ask: how does the auto-links for commits in the
>         new
>         > bugzilla work? I mean, if I write something like:
>         >    commit abcde12345
>         > then the "abcde12345" will become a link to the sources in
>         the product
>         > the current bug is filled for. It works similarly to bug
>         auto-link
>         > references, which is nice.
>         
>         Related to this, I've proposed to also link "branch wip/..."
>         in this
>         bug: https://bugzilla.gnome.org/show_bug.cgi?id=744068
>         
>         > My problem is when one change for a product A requires also
>         a change
>         > in product B and I reference commits for both products
>         within one bug
>         > report. That may cause one of the commit links invalid.
>         >
>         > Is there a way to tell the comment parser that the commit
>         itself
>         > belongs to another product than the one the bug is filled
>         for?
>         
>         If we come with a way to specify the module, would be nice to
>         adapt my
>         patch likewise :)
>         
>         Regards,
>         Xavier Claessens.
>         
>         
>         _______________________________________________
>         desktop-devel-list mailing list
>         desktop-devel-list gnome org
>         https://mail.gnome.org/mailman/listinfo/desktop-devel-list
>
>
>
> -- 
>   Jasper