Re: Brasero shouldn't look for dvdcss_inerface_2

[Emmanuele Bassi <ebassi gmail com>]

Hi;

thanks for the patch. Would it be possible for you to attach it to a
bug on Bugzilla?

You can use:

  https://bugzilla.gnome.org/enter_bug.cgi?product=brasero

As far as I can see, the code always looked for the
`dvdcss_interface_2` symbol since its inclusion in the repository, but
since the DVDCSS plugin dlopen()s the library instead of linking
against it (and since lots of distributions cannot ship libdvdcss in
order to comply with legal requirements), nobody noticed the breakage.

Ciao,
 Emmanuele.


On 26 March 2017 at 10:12, Que Quotion <quequotion gmail com> wrote:
> I am aware that brasero has been left unmaintained for quite some time. It
> still happens to be a very useful program with the exception of one
> bug--failing to find libdvdcss because it checks for a symbol,
> dvdcss_interface_2, which was dropped from libdvdcss about three years ago.
> https://code.videolan.org/videolan/libdvdcss/commit/8331d8da6392b993f7b0ffa223d8d7a3ccd7f0ae
>
> Several distributions are already patching around this in their packaging:
> Ubuntu -
> https://bugs.launchpad.net/ubuntu/+source/brasero/+bug/1577268/comments/4
> Debian - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800833#12
> Fedora - https://bugzilla.redhat.com/show_bug.cgi?id=1193628I
>
> If anyone has a moment, and the authority, to patch this in it would be
> much appreciated.
>
> --- brasero-3.12.1/plugins/dvdcss/burn-dvdcss.c
> +++ brasero-3.12.1/plugins/dvdcss/burn-dvdcss.c
> @@ -95,8 +95,6 @@
>      if (!module)
>          goto error_doesnt_exist;
>
> -    if (!g_module_symbol (module, "dvdcss_interface_2", &address))
> -        goto error_version;
>
>      if (!g_module_symbol (module, "dvdcss_open", &address))
>          goto error_version;
> _______________________________________________
> desktop-devel-list mailing list
> desktop-devel-list gnome org
> https://mail.gnome.org/mailman/listinfo/desktop-devel-list



-- 
https://www.bassi.io
[@] ebassi [@gmail.com]