Re: [Easytag-mailing] Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

["Götz Waschk" <goetz waschk gmail com>]

On Nov 23, 2007 12:45 AM, Jérôme COUDERC <easytag gmail com> wrote:
> I've tried the attached patch. It detects correctly the version of the
> library, but I've noted that now it doesn't add "-lmp4v2" to the
> compilator flags....
Hi Jérôme,

oh right, autoheader didn't pick up the mp4v2 definition, don't ask me
why. But it is working fine if you rearrange it a bit, see the
attached patch.

Regards, Götz

-- 
AL I:40: Do what thou wilt shall be the whole of the Law.

--- easytag-2.1.3/src/mp4_tag.c.mpeg4ip	2007-06-14 17:52:38.000000000 -0400
+++ easytag-2.1.3/src/mp4_tag.c	2007-11-23 01:55:54.049245774 -0500
@@ -185,7 +185,11 @@
      * Picture *
      ***********/
     // There is only one picture!
+#ifdef NEWMP4
+    if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize,0 ) )
+#else
     if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize ) )
+#endif
     {
         Picture *pic = Picture_Allocate();
         pic->size = coverSize;
--- easytag-2.1.3/configure.in.mpeg4ip	2007-10-07 04:00:55.000000000 -0400
+++ easytag-2.1.3/configure.in	2007-11-23 01:56:01.809566984 -0500
@@ -313,7 +313,6 @@
 if test "x$enable_mp4" = "xyes"; then
     dnl Librairies required for mp4 files, if not found 'enable_mp4' is disabled
     AC_CHECK_LIB(m, cos)
-    dnl AC_CHECK_LIB(mp4v2, MP4Read, , mp4_available=no)
     AC_CHECK_LIB(mp4v2, MP4GetTrackMediaDataName, , mp4_available=no)
 fi
 
@@ -327,6 +326,12 @@
         echo "*** (Install libmp4v2 to enable it)"
         echo "***"
     else
+        AC_COMPILE_IFELSE([
+           #include <mp4.h>
+           main () {
+           MP4FileHandle hFile;
+           MP4GetMetadataCoverArt(hFile, NULL, NULL,0); }
+        ], AC_DEFINE(NEWMP4,1,[Define for MP4 lib with multiple image support]),)
         AC_MSG_RESULT(yes)
         AC_DEFINE(ENABLE_MP4,1,[Define for MP4 support])
     fi