Memory leaks in epiphany 1.0.6
- From: JF Rameau <jframeau cyberdeck com>
- To: epiphany-list gnome org
- Subject: Memory leaks in epiphany 1.0.6
- Date: Fri, 05 Dec 2003 18:56:57 +0100
Hello,
i think there are two little leaks in Epiphany 1.0.6. One in
mozilla-embed.cpp and another in downloader-view.c. The two diffs
enclosed with this mail are more expressive.
Hope that this will help you.
jean-françois
--- epiphany-1.0.6-dev/embed/downloader-view.c 2003-08-20 00:36:50.000000000 +0200
+++ epiphany-1.0.6/embed/downloader-view.c 2003-11-24 18:18:04.000000000 +0100
@@ -1092,6 +1092,7 @@
ephy_embed_utils_nohandler_dialog_run (parent);
}
+ gnome_vfs_mime_application_free(app);
g_free(mime);
}
--- epiphany-1.0.6-dev/embed/mozilla/mozilla-embed.cpp 2003-11-13 18:21:06.000000000 +0100
+++ epiphany-1.0.6/embed/mozilla/mozilla-embed.cpp 2003-11-24 17:15:38.000000000 +0100
@@ -552,18 +552,22 @@
gresult result;
if (ephy_embed_get_location (embed, TRUE, &location) != G_OK)
- return G_FAILED;
- g_return_val_if_fail (location != NULL, G_FAILED);
- if ((s = mozilla_embed_get_uri_parent (location)) != NULL)
- {
- g_free (s);
- result = G_OK;
- }
- else
- {
- result = G_FAILED;
- }
-
+ {
+ result = G_FAILED;
+ }
+ else
+ {
+ g_return_val_if_fail (location != NULL, G_FAILED);
+ if ((s = mozilla_embed_get_uri_parent (location)) != NULL)
+ {
+ g_free (s);
+ result = G_OK;
+ }
+ else
+ {
+ result = G_FAILED;
+ }
+ }
g_free (location);
return result;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]