Re: [Epiphany] Toolbar editor patch take 2

[Marco Pesenti Gritti <mpeseng tin it>]

On Mon, 2003-03-10 at 20:04, iain wrote:
> So the crash was in the new libegg code, so I just back ported the patch
> to the old code that was in epiphany.
> 
> Here's the new patch.

Iain, I know you are now going to kill me but ...

After thinking to this a bit I think we should not add such complexity
in epiphany.
Toolbar editing seem something that most people are unlikely to use but
on the other hand it's a great usability gain.
We should try our best to encourage people to use it by keeping the
editor the simpler it's possible.
In this context I dont think per toolbar style configurability it's
important enough, or an usability gain, to add complexity to the editor
...

Still I think we should keep sharing the toolbar editor code in our
projects. There is a lot of work to do and it's important to share it.
I'm not opposed to the backend code, if you can have these properties in
libegg it certainly make sense to allow them in the toolbar editor xml
too. If you could commit that part I'd appreciate.

I think we should go ahead with the "get it in libegg" project. So we
can find a generic solution to this problem too (something good for all
GNOME apps). What do you think ?
One issue I found with that is that we use libxml, I guess we need to
move to g_markup if we want to get that code in gtk.

Marco