Re: [Epiphany] [patch] Favicons in tabs

From: Marco Pesenti Gritti <mpeseng tin it>
To: Christian Persch <christian hpersch de>
Cc: epiphany devel list <epiphany mozdev org>
Subject: Re: [Epiphany] [patch] Favicons in tabs
Date: 30 Mar 2003 17:53:58 +0200

On Fri, 2003-03-28 at 14:58, Christian Persch wrote:
> The attached patch implements this.
> 
> Regards,
>  Christian.

Hi,

no one is complaining so I reviewed your patch.

EphyNotebook should not know about favicon cache (files in lib/ are
generally meant to be independent from the other code).
I think we should add a set_icon function on the notebook and call it
from EphyTab on favicons changes. Like we do for title.

Marco

References:
- [Epiphany] [patch] Favicons in tabs
  - From: Christian Persch

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]