I helped a friend install debian on his laptop yesterday and everything went (surprisingly) well, except he was not happy with scrolling in evince. In particular, scrolling by dragging wasn't easy with his 2-button touchpad: you had to emulate button 2 by clicking both buttons and then drag on the touchpad. Frankly, this was tending towards gymnastics! Thinking about it, I realised that there isn't any meaning currently assigned to clicking on the document with the CTRL key down. So I came up with a (trivial) patch that treats CTRL+(any button) as button 2. Now you can drag around with minimal dexterity :-) I've got some questions: 1) Is this the correct place to be posting questions/patches etc.? Should I have filed a wishlist bug on the bug tracker instead? 2) Is this approach to fixing the problem reasonable? Or should it be something customisable? 3) Do you guys agree that there's actually a problem? (of course, I hope that the answer to the last will be yes...) Rupert
diff --git a/libview/ev-view.c b/libview/ev-view.c
index ee81680..9f88e51 100644
--- a/libview/ev-view.c
+++ b/libview/ev-view.c
@@ -3064,13 +3064,13 @@ ev_view_button_press_event (GtkWidget *widget,
view->window_child_focus = NULL;
}
- view->pressed_button = event->button;
+ view->pressed_button = (event->state & GDK_CONTROL_MASK) ? 2 : event->button;
view->selection_info.in_drag = FALSE;
if (view->scroll_info.autoscrolling)
return TRUE;
- switch (event->button) {
+ switch (view->pressed_button) {
case 1: {
EvImage *image;
EvAnnotation *annot;
Attachment:
pgpyCLpjoutv8.pgp
Description: PGP signature