Re: [Evolution-hackers] Re: patch for bug #60463

[Rodrigo Moya <rodrigo novell com>]

On Mon, 2004-06-28 at 23:54 -0600, P Chenthill wrote:
> hi,
>    Attached a patch which checks for the default zone,  converts the
> time to the default zone and sends it to evolution shell to display free
> busy status.
> 
please send the patch in unified format, that is:

	cvs -z3 diff -u

> 811c811,814
> <                               itt = icaltime_from_timet (t, 0);
> ---
> >                               if (default_zone)
> >                                       itt =
> icaltime_from_timet_with_zone (t, 0, default_zone);
> >                               else
> >                                       itt =
> icaltime_from_timet_with_zone (t, 0, 0);
> 
you should use icaltime_from_timet when there is no timezone, not using
a NULL timezone on the call to icaltime_from_timet_with_zone

> >                              time_t start, time_t end, GList
> **freebusy,icaltimezone *default_zone);
> 
leave a space after the ','

Also, you are missing a ChangeLog entry.

cheers