Re: [evolution-patches] patch for week_view keyboard navigation.

[Harry Lu <harry lu sun com>]

Hi, JP,
    Bolian left SUN last week for his further education in USA. Wu Yang also finished his internship in SUN.
    I will take care of what they left. Sorry I am not very familiar with those code, either.
    Attached is the patch for the fix. Please review it.
       Harry
   

JP Rosevear wrote:

I'm resending this because I can't seem to get a mail through to Bolian
Yin.

On Fri, 2003-12-05 at 04:01, Bolian Yin wrote:
  

Hi,

this patch fix a event/jump button tabbing bug.
    

In general there seems to be a problem with the week view focus code, as
seen in http://bugzilla.ximian.com/show_bug.cgi?id=51665.  Could you
look into this bug and also explain to me the algorithm used in
e_week_view_focus?

-JP
  

Index: calendar/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2012
diff -u -r1.2012 ChangeLog
--- calendar/ChangeLog	16 Dec 2003 23:29:06 -0000	1.2012
+++ calendar/ChangeLog	17 Dec 2003 10:33:05 -0000
@@ -1,3 +1,10 @@
+2003-12-17  Harry Lu  <harry lu sun com>
+
+	Fixes #51665.
+
+	* gui/e-week-view.c: (e_week_view_focus): call 
+	e_week_view_check_layout() so that the spans won't be NULL.
+
 2003-12-16  Rodrigo Moya <rodrigo ximian com>
 
 	Fixes part of #41237
Index: calendar/gui/e-week-view.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-week-view.c,v
retrieving revision 1.194
diff -u -r1.194 e-week-view.c
--- calendar/gui/e-week-view.c	10 Dec 2003 04:00:24 -0000	1.194
+++ calendar/gui/e-week-view.c	17 Dec 2003 10:33:09 -0000
@@ -1008,6 +1008,8 @@
 
 	week_view = E_WEEK_VIEW (widget);
 
+	e_week_view_check_layout (week_view);
+
 	if (week_view->focused_jump_button == E_WEEK_VIEW_JUMP_BUTTON_NO_FOCUS) {
 		last_focus_event_num = week_view->editing_event_num;
 		last_focus_span_num = week_view->editing_span_num;