Re: [evolution-patches] Patch for shell crash (#43322)
- From: Ettore Perazzoli <ettore ximian com>
- To: Mike Kestner <mkestner ximian com>
- Cc: patches <evolution-patches ximian com>
- Subject: Re: [evolution-patches] Patch for shell crash (#43322)
- Date: 20 May 2003 11:16:34 -0400
On Mon, 2003-05-19 at 23:56, Mike Kestner wrote:
> Your ChangeLog indicates that in shell_view_weak_notify you are setting
> parent = NULL, but your patch does not show such a change since it is
> already being set to NULL in that func in cvs trunk.
Ooops, I'll fix that. :-)
> The discrepancy got
> me interested enough to wonder why shell_view_weak_notify does not call
> cleanup_discovery like the other notify callbacks do. :)
Thing is, if the storage or the shell go away before the "discovery" is
finished, you want to clean up and cancel it; but if the shell view goes
away, it should keep going.
I'll fix the ChangeLog and commit.
-- Ettore
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]