Re: [evolution-patches] Patch for mail-config glade higification

[Anna Marie Dirks <anna ximian com>]

Martyn,

For the most part, this patch looks good. Thank you for spending time on
this. I have a few concerns about it: 

1. The "Server Type" labels on the Receiving Mail and Sending Mail pages
are not correctly capitalized.

2. The "Restore Defaults" button should have an icon, and an alignment
around it so as to restrict its size. This button should also have an
access key.

3. "Authentication Type" is incorrectly capitalized on the Sending Mail
page. Ideally, we'd change the "Authentication type" label to just
"Type", and would pack the authentication widgets into a table so as to
give that portion of the dialog some more symmetry. 

4. There is an inordinate amount of vertical space around the hrule on
the Sending Mail tab. (The amount of space there is inconsistent with
other tabs.) Let me know if you need a screenshot to see this.

4. I'd really like us to get rid of the various help messages in this
dialog. Specifically, the notes about password prompting, the
descriptions of server types, and the explanation of the use of the
account name can all be removed as far as I am concerned. Ettore, other
hackers wish to differ? 

5. The "Add new signature.." button is incorrectly capitalized, and
lacks an icon.

6. When you get around to fixing the "Receiving Options" stuff, please
note that most of the items enclosed in frames on that page lack
appropriate accelerators. 

So, please address the capitalization, spacing, etc issues and resubmit
this patch. Thanks!

cheers,
Anna



On Sun, 2003-10-19 at 11:57 +0100, Martyn Russell wrote:
> Hi, 
> 
> I have spent some time updating the mail-config.glade file to give a
> better look which is more inline with the HIG.
> 
> I have supplied the diff to CVS HEAD (from the last hour or so) from the
> mail directory.
> 
> Note: currently the "receiving options" tab under the "evolution account
> editor" window shows parts which have not been higified, this (I
> believe) will require code changes (not just glade changes), which I
> will look into.
> 
> I plan to upgrade other glade files at some point too, unless people
> have objections too that or are currently already in the process of
> doing the same thing. :)
> 
> Thanks,
> 
> -- 
> Regards,
> Martyn
-- 
Anna Marie Dirks <anna ximian com>