Re: [evolution-patches] fix for addressbook db corruption crash
- From: Chris Toshok <toshok ximian com>
- To: Not Zed <notzed ximian com>
- Cc: evolution-patches ximian com
- Subject: Re: [evolution-patches] fix for addressbook db corruption crash
- Date: Thu, 01 Apr 2004 23:24:03 -0800
odd.. same backtrace?
Chris
On Fri, 2004-04-02 at 14:39 +0800, Not Zed wrote:
> FWIW It still crashes with this applied.  i even did a full make
> clean/make to make sure i got it (my sole achievement today so far, its
> just not happening today).
> 
>  Michael
> 
> On Thu, 2004-04-01 at 11:15 -0800, Chris Toshok wrote:
> > If for any reason a db entry gets partially overwritten and is left in a
> > bad state (where the data is trashed but the db still thinks there's a
> > value there), e-d-s can get really unstable.  The trouble is all the
> > code assumes there's a UID in the EContact that is created from the
> > vcard, and if that vcard attribute has been trashed and is missing,
> > e-d-s crashes.
> > 
> > So, this fix parses the vcard, and if there's no UID set on the contact
> > it sets it to be the same as the db key (which it should always be.)
> > 
> > This has the added benefit (over ignoring the corrupted entry) of having
> > the corrupted entry show up in the addressbook view, so you can
> > edit/fix/delete it.
> > 
> > Fixes Michael's crash from last night.
> > 
> > Chris
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]