[evolution-patches] Re: gtkhtml, patch for 63597, can't open link with keyboard when reading mail

[Radek Doulik <rodo ximian com>]

Hi Eric,

I think it should be handled differently. The signal should be emitted from iframe's gtkhtml widget key_press handler and pass top level html to g_signal_emit (you may use gtk_html_get_top_html method or html_engine_get_top_html engine). That's how we do it at other places.

It means replacing
>     g_signal_emit (html, signals [LINK_CLICKED], 0, url);
with
>     g_signal_emit (gtk_html_get_top_html (html), signals [LINK_CLICKED], 0, url);

Cheers
Radek

On Sun, 2004-08-22 at 20:31 +0800, Eric Zhao wrote:
> Hi,
>
> The attachment is a patch for bug 
> 63597(http://bugs.ximian.com/show_bug.cgi?id=63597).
>
> It can be reproduced by:
>
> Steps to reproduce the problem:
> 1. start evolution
> 2. open a HTML format mail which contains link
> 3. press F7 to enable caret mode and move the cursor to the link
> 4. press Enter to activate the link.
>
> Actual Results:
> nothing happens.
>
> The reason is that the mail message is placed in an iframe. 
> And it is the focus object of the toplevel gtkhtml.
> So in the signal hander of key pressed event, if the focus object
> is a frame or an iframe,  we should check the frame's focus object 
> recursively,
> otherwise we can't get the link object properly.
>
> Could you help give the patch a review? Thanks!
>
> Regards,
> Eric