[evolution-patches] 69851, remember password setting lost

[Not Zed <notzed ximian com>]

introduced by a previous fix for another problem.

this seems to fix it

--

Michael Zucchi <notzed ximian com> "Evolution - Mostly Practiced By Dumb People" Novell's Evolution and Free Software Developer

Index: mail/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3444.2.30
diff -u -p -r1.3444.2.30 ChangeLog
--- mail/ChangeLog	1 Dec 2004 03:41:21 -0000	1.3444.2.30
+++ mail/ChangeLog	1 Dec 2004 07:02:47 -0000
@@ -1,3 +1,10 @@
+2004-12-01  Not Zed  <NotZed Ximian com>
+
+	** See bug #69851.
+
+	* mail-account-gui.c (save_service): dont skip the save_password
+	setting if we don't have a needs_auth widget.
+
 2004-11-22  Not Zed  <NotZed Ximian com>
 
 	** See bug #69339.
Index: mail/mail-account-gui.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-account-gui.c,v
retrieving revision 1.171.14.9
diff -u -p -r1.171.14.9 mail-account-gui.c
--- mail/mail-account-gui.c	30 Nov 2004 07:56:26 -0000	1.171.14.9
+++ mail/mail-account-gui.c	1 Dec 2004 07:02:48 -0000
@@ -2305,15 +2305,17 @@ save_service (MailAccountGuiService *gsv
 			url->user = g_strstrip (g_strdup (str));
 	}
 	
-	if (CAMEL_PROVIDER_ALLOWS (gsvc->provider, CAMEL_URL_PART_AUTH)
-	    && url->user && gsvc->needs_auth && gtk_toggle_button_get_active(gsvc->needs_auth)) {
-		CamelServiceAuthType *authtype;
+	if (CAMEL_PROVIDER_ALLOWS (gsvc->provider, CAMEL_URL_PART_AUTH) && url->user) {
+		if (gsvc->needs_auth && gtk_toggle_button_get_active(gsvc->needs_auth)) {
+			CamelServiceAuthType *authtype;
 		
-		authtype = g_object_get_data(G_OBJECT(gsvc->authitem), "authtype");
-		if (authtype && authtype->authproto && *authtype->authproto)
-			url->authmech = g_strdup (authtype->authproto);
-		
-		service->save_passwd = gtk_toggle_button_get_active (gsvc->remember);
+			authtype = g_object_get_data(G_OBJECT(gsvc->authitem), "authtype");
+			if (authtype && authtype->authproto && *authtype->authproto)
+				url->authmech = g_strdup (authtype->authproto);
+		}
+
+		if (gsvc->remember)
+			service->save_passwd = gtk_toggle_button_get_active (gsvc->remember);
 	}
 	
 	if (CAMEL_PROVIDER_ALLOWS (gsvc->provider, CAMEL_URL_PART_HOST)) {