Re: [evolution-patches] GNOME Bounty feturerequest #127557

[Rodrigo Moya <rodrigo novell com>]

On Fri, 2004-11-19 at 14:57 +0100, Philip Van Hoof wrote:
> More information:
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=127557
> http://www.gnome.org/bounties/Tasks.html#127557
> 
some comments below:

> +static gchar *
> +icaltimetype_to_gchar (icaltimetype *t)
> +{
> +       if (t) return g_strdup_printf (_("%2d/%2d/%4d %2d:%2d:%2d"),
> t->month, t->day, t->year, t->hour, t->minute, t->second);
> +       else return g_strdup ("");
> +}
please use evolution coding standards, so,
	if (t)
		...
	else
		return ...

> +       /* ask the user for destination file */
> +#ifdef USE_GTKFILECHOOSER
> +       dialog = gtk_file_chooser_dialog_new (_("Select destination
> file"),
> +                                             NULL,
> +
> GTK_FILE_CHOOSER_ACTION_SAVE,
> +                                             GTK_STOCK_CANCEL,
> GTK_RESPONSE_CANCEL,
> +                                             GTK_STOCK_SAVE,
> GTK_RESPONSE_OK,
> +                                             NULL);
I guess we should probably put this code in one function and call that
function from do_save_calendar*

> +       uri = gnome_vfs_uri_new (dest_uri);
> +       result = gnome_vfs_open_uri (&handle, uri,
> GNOME_VFS_OPEN_WRITE);
> +       if (result != GNOME_VFS_OK) {
> +               gnome_vfs_create (&handle, dest_uri,
> GNOME_VFS_OPEN_WRITE, TRUE, GNOME_VFS_PERM_USER_ALL);
> +               result = gnome_vfs_open_uri (&handle, uri,
> GNOME_VFS_OPEN_WRITE);
> +       }
could you also make do_save_calendar use gnome_vfs_* instead of using an
ECal?

> +                       /* I don't know, the documentation told me to
> do this */
> +                       e_cal_component_commit_sequence (comp);
>
this is needed when you change some fields, like the start date. Why did
you add it here?
-- 
Rodrigo Moya <rodrigo novell com>