Re: [evolution-patches] patch for Natzilla bug 52476

[Jeffrey Stedfast <fejj ximian com>]

camel_tag_set (tag_list, "name", NULL); will clear a tag. no need to
write a camel_tag_clear() function.

also, the "None" item is simply no good which is bad for multiple
reasons:

1. we are feature/ui frozen
2. there is a Clear Flag menu item already (which, btw, implements
exactly what you are trying to do)
3. adding a None flag item is inconsistent

Jeff

On Thu, 2004-01-29 at 17:56, Larry Siden wrote:
> I would still like to know why my patch was rejected.  You did not offer
> any explanation of what you found wrong or how I might do this
> differently without touching "camel".  I would be happy to learn.
> 
> 
> On Wed, 2004-01-28 at 10:25, Jeffrey Stedfast wrote:
> > the patch is wrong.
> > 
> > there is no need to change camel at all.
> > 
> > Jeff
> > 
> > On Wed, 2004-01-28 at 08:13, Larry Siden wrote:
> > > My apologies for not including the attachment.  
> > > 
> > > Never before noticed the "Clear Flag" in the context menu.  Wish I'd
> > > known that before.  Could have saved the learning experience.
> > > 
> > > On Tue, 2004-01-27 at 23:15, Jeffrey Stedfast wrote:
> > > > you could already do this. right-click and select Clear Flag.
> > > > 
> > > > also note that you sent no patch and likely it will be hard to merge in
> > > > seeing as how 1.5 has changed quite a bit.
> > > > 
> > > > Jeff
> > > > 
> > > > On Tue, 2004-01-27 at 23:13, Larry Siden wrote:
> > > > > The attached patch is meant to be run a gainst the Evolution 1.4.5
> > > > > release (-r EVOLUTION_1_4_5).  It should be run with -p0 in the top
> > > > > project folder.  When done, it will allow users to clear the follow-up
> > > > > tag from a message or messages for which it was previously set.  
> > > > > 
> > > > > I hope it will be merged and released with 1.5 as well, but I am not
> > > > > currently set up to build and test 1.5.
> > > > > 
> > > > > Thank you,
> > > > > Larry Siden
> > > > > http://umich.edu/~lsiden
> > > > > 
> > > > > _______________________________________________
> > > > > Evolution-patches mailing list
> > > > > Evolution-patches lists ximian com
> > > > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > > > > 
> > > > 
> > 
>