Re: [evolution-patches] Re: Prettify folder property dialog

[Christian Neumair <chris gnome-de org>]

Am Do, den 03.06.2004, 10:47 Uhr +0800 schrieb Not Zed:
> On Wed, 2004-06-02 at 12:26 -0400, Rodney Dawes wrote: 
> > On M�, 2004-06-02 at 16:22 +0200, Christian Neumair wrote:
> > > Rodney Dawes schrieb: 
> > > 
> > > > Some comments below. 
> > > > 
> > > > On M�, 2004-06-02 at 12:55 +0200, Christian Neumair wrote:
> > > >> The attached patch pretifies the folder property dialog and moves it
> > > >> towards HIG compliance.
> > > >> Any comments/suggestions?
> > > > 
> > > >> @@ -56,7 +56,7 @@
> > > >>         CamelArgV *argv = prop_data->argv;
> > > >>         int i;
> > > >>         
> > > >> -       if (response != GTK_RESPONSE_OK) {
> > > >> +       if (response != GTK_RESPONSE_CLOSE) {
> > > >>                 gtk_widget_destroy (dialog);
> > > >>                 return;
> > > >>         }
> > > > 
> > > > Shouldn't the response always be GTK_RESPONSE_CLOSE? Why would we check
> > > > for !=? We're just going to close it all the time no matter what we get
> > > > here, aren't we?
> > > 
> > > There is also a destroy reponse. 
> > 
> > And it presumably also destroys the window. So, I don't see why we need
> > to handle them differently, unless we are doing something when we click
> > the "Close" button.
> 
> Shouldn't it remain an Ok button anyway?  This dialogue takes input.
> 
> And it has values which need to be applied when you hit ok.  They
> can't be instant apply - reindexing a folder can minutes to hours.

You gave a random comment without taking a look at the source code.
The dialog takes no input at all. It displays the folder name in a
label. If you want to rename a folder, you'll have to right-click it and
select the rename action.

regs,
 Chris