Re: [evolution-patches] e-error border width fix

[Not Zed <notzed ximian com>]

On Thu, 2004-06-03 at 22:45 -0400, Rodney Dawes wrote:
> On Thu, 2004-06-03 at 16:38 -0400, William Jon McCann wrote:
> > Hi,
> > 
> > Here is a minor patch to add the HIG border width to the error dialogs.
> > 
> > OK to commit?
> > 
> > Jon
>
> This isn't the Right Way. This also doesn't make it 12 pixels, it makes
> it 13 pixels with the default gtk+ setup. This also doesn't actually
> make the dialog HIG-compliant. It needs a lot more changes to acheive
> that unfortunately.

Hmm?  It was based on the glade file you provided for it.  Pixel for pixel.

> However, the best way to get HIG-compliant borders around the window, is
> to do the following:
>
> 	gtk_container_set_border_width (GTK_CONTAINER (GTK_DIALOG
> (warning_dialog)->vbox), 0);
> 	gtk_container_set_border_width (GTK_CONTAINER (GTK_DIALOG
> (warning_dialog)->action_area), 12);
>
> And then set the border width of whatever you are packing into the
> dialog->vbox widget, to 12.
>
> -- dobey

--

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer