[evolution-patches] Re: gtkhtml, #59935, crash composing mail

[Radek Doulik <rodo ximian com>]

Hi Eric,

thanks for looking into this. Your patch is correct. Please commit it and close the bug.

Cheers
Radek

On Mon, 2004-06-14 at 18:25 +0800, Eric Zhao wrote:
> Hi,
>    I have just fixed bug #59935.  The bug can be reproduced as follows:
>
> (1) composing a mail with HTML turned on.
> (2) insert a link
> (3) insert some spaces before the link
> (4) move the caret to the link, then crash
>
>
> I  think the bug the reason is: when  a space is inserted before the link, 
> the function  remove_empty_and_merge will be invoked and the link object
> will be destroyed. But  engine->focus_object is still pointing to the 
> destoryed
> link object. Then crash...
>
> I think since the focus has no use when it's in edit mode,  we can just 
> disable
> html_engine_update_focus_if_necessary when in edit mode. The attachment is
> a quite simple patch.
>
> Regards,
> Eric