Re: [evolution-patches] A patch for calendar based on trunk

[JP Rosevear <jpr ximian com>]

On Mon, 2004-03-01 at 02:12, Kidd Wang wrote:
> Hi,
> 
> This patch is aimed for trunk. We have found a bug in calendar which can 
> be reproduced as follows:
> 1. Invoke evolution on Japanese locales.
> 2. Choose [File] -> [New] -> [Appointment].
> 3. Select [Appointment] tab.
> 4. Choose an arrow button in "Start time" or "End time".
> 
> Then Japanese "01:00 AM" is longer than the text box, so the string is 
> shifted left.
> 
> Enclosed is the snapshot and a patch to fix that. Would you like to 
> spend a little time to review it?

I suspect hardcoding a larger value is not the way to fix this.  IIRC
this hard code is there because ages ago gtk did not properly size
allocate the combo box based on the child size.  The hard coded size may
not even be necessary now, the other option would be to calculate the
size of the time strings and then set the size request to the maximal
size plus some padding.

-JP
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.