Re: [evolution-patches] Few Cosmetic changes, required by bug nos. 48115, 48130.

From: hpnadig <hp ndeepak info>
To: Rodrigo Moya <rodrigo ximian com>
Cc: evolution-patches lists ximian com
Subject: Re: [evolution-patches] Few Cosmetic changes, required by bug nos. 48115, 48130.
Date: Wed, 17 Mar 2004 17:16:14 -0500

attached, are the new diffs.

On Wed, 2004-03-17 at 11:45 +0100, Rodrigo Moya wrote:

> On Wed, 2004-03-17 at 10:31 -0500, hpnadig wrote:
> 
> > hi,
> > 
> > This one is just for the minor changes addressed in those two bugs
> > ( 48115, 48130 ). Attached are the three diffs and the ChangeLog.
> > 
> all look ok except for the e-calendar-table.etspec changes. There is no
> need to order alphabetically, and in fact, if you change the order in
> the etspec file only, the task list will do a lot of weird things. This
> is because that order is also used in e-cal-model*.[ch], so if you
> change the order in the etspec file, you need to change it there also.
> 
> So, since there is no need for it to be ordered alphabetically, please
> send a new patch containing only the capitalizations.
> 
> cheers

--

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2192
diff -u -r1.2192 ChangeLog
--- ChangeLog   15 Mar 2004 21:26:33 -0000      1.2192
+++ ChangeLog   17 Mar 2004 04:29:09 -0000
@@ -1,3 +1,11 @@
+2004-03-17  hpnadig  <hp ndeepak info>
+
+       * gui/dialogs/task-page.glade: Capitalized words changed. Solves 48115.
+
+       * gui/dialogs/task-details-page.glade: s/Date Completed/Date completed.
+
+       * gui/e-calendar-table.etspec: Capitalization checked. Solves 48130.
+
 2004-03-15  JP Rosevear  <jpr ximian com>

        * gui/e-tasks.c (search_bar_sexp_changed_cb): set the search query

Index: task-page.glade
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/task-page.glade,v
retrieving revision 1.26
diff -u -r1.26 task-page.glade
--- task-page.glade	12 Jan 2004 21:19:09 -0000	1.26
+++ task-page.glade	16 Mar 2004 17:49:45 -0000
@@ -106,7 +106,7 @@
 		  <child>
 		    <widget class="GtkLabel" id="label6">
 		      <property name="visible">True</property>
-		      <property name="label" translatable="yes">Sta_rt Date:</property>
+		      <property name="label" translatable="yes">Sta_rt date:</property>
 		      <property name="use_underline">True</property>
 		      <property name="use_markup">False</property>
 		      <property name="justify">GTK_JUSTIFY_CENTER</property>
@@ -131,7 +131,7 @@
 		  <child>
 		    <widget class="GtkLabel" id="label5">
 		      <property name="visible">True</property>
-		      <property name="label" translatable="yes">_Due Date:</property>
+		      <property name="label" translatable="yes">_Due date:</property>
 		      <property name="use_underline">True</property>
 		      <property name="use_markup">False</property>
 		      <property name="justify">GTK_JUSTIFY_CENTER</property>

Index: task-details-page.glade
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/task-details-page.glade,v
retrieving revision 1.18
diff -u -r1.18 task-details-page.glade
--- task-details-page.glade	12 Jan 2004 21:19:09 -0000	1.18
+++ task-details-page.glade	16 Mar 2004 17:50:06 -0000
@@ -246,7 +246,7 @@
 		  <child>
 		    <widget class="GtkLabel" id="date_completed_label">
 		      <property name="visible">True</property>
-		      <property name="label" translatable="yes">_Date Completed:</property>
+		      <property name="label" translatable="yes">_Date completed:</property>
 		      <property name="use_underline">True</property>
 		      <property name="use_markup">False</property>
 		      <property name="justify">GTK_JUSTIFY_CENTER</property>

Index: e-calendar-table.etspec
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-calendar-table.etspec,v
retrieving revision 1.8
diff -u -r1.8 e-calendar-table.etspec
--- e-calendar-table.etspec     16 Nov 2003 22:37:13 -0000      1.8
+++ e-calendar-table.etspec     17 Mar 2004 11:19:50 -0000
@@ -2,14 +2,14 @@
   <ETableColumn model_col= "0" _title="Categories" expansion="1.0" minimum_width="10" resizable="true" cell="calstring" compare="string"/>
   <ETableColumn model_col= "1" _title="Classification" expansion="1.0" minimum_width="10" resizable="true" cell="classification" compare="string" priority="-1"/>
   <ETableColumn model_col="4" _title="Description" expansion="2.0" minimum_width="10" resizable="true" cell="calstring" compare="string" priority="-1"/>
-  <ETableColumn model_col= "5" _title="Start Date" expansion="2.0" minimum_width="10" resizable="true" cell="dateedit" compare="date-compare" priority="-2"/>
+  <ETableColumn model_col= "5" _title="Start date" expansion="2.0" minimum_width="10" resizable="true" cell="dateedit" compare="date-compare" priority="-2"/>
   <ETableColumn model_col="6" _title="Alarms" expansion="1.0" minimum_width="10" resizable="true" cell="calstring" compare="string" disabled="true"/>
   <ETableColumn model_col="7" pixbuf="icon" _title="Type" expansion="1.0" minimum_width="16" resizable="false" cell="icon" compare="integer" priority="-4"/>
   <ETableColumn model_col= "8" _title="Summary" expansion="3.0" minimum_width="10" resizable="true" cell="calstring" compare="string" priority="10"/>
-  <ETableColumn model_col= "10" _title="Completion Date" expansion="2.0" minimum_width="10" resizable="true" cell="dateedit" compare="date-compare" priority="-2"/>
+  <ETableColumn model_col= "10" _title="Completion date" expansion="2.0" minimum_width="10" resizable="true" cell="dateedit" compare="date-compare" priority="-2"/>
   <ETableColumn model_col="11" pixbuf="complete" _title="Complete" expansion="1.0" minimum_width="16" resizable="false" cell="checkbox" compare="integer" priority="-4"/>
-  <ETableColumn model_col= "12" _title="Due Date" expansion="2.0" minimum_width="10" resizable="true" cell="dateedit" compare="date-compare" priority="-2"/>
-  <ETableColumn model_col= "13" _title="Geographical Position" expansion="1.0" minimum_width="10" resizable="true" cell="calstring" compare="string"/>
+  <ETableColumn model_col= "12" _title="Due date" expansion="2.0" minimum_width="10" resizable="true" cell="dateedit" compare="date-compare" priority="-2"/>
+  <ETableColumn model_col= "13" _title="Geographical position" expansion="1.0" minimum_width="10" resizable="true" cell="calstring" compare="string"/>
   <ETableColumn model_col= "15" _title="% Complete" expansion="1.0" minimum_width="10" resizable="true" cell="percent" compare="percent-compare" priority="-3"/>
   <ETableColumn model_col= "16" _title="Priority" expansion="1.0" minimum_width="10" resizable="true" cell="priority" compare="priority-compare" priority="-3"/>
   <ETableColumn model_col="17" _title="Status" expansion="1.0" minimum_width="10" resizable="true" cell="calstatus" compare="string" priority="-1"/>

Follow-Ups:
- Re: [evolution-patches] Few Cosmetic changes, required by bug nos. 48115, 48130.
  - From: Rodrigo Moya

References:
- [evolution-patches] Few Cosmetic changes, required by bug nos. 48115, 48130.
  - From: hpnadig
- Re: [evolution-patches] Few Cosmetic changes, required by bug nos. 48115, 48130.
  - From: Rodrigo Moya

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]