Re: [evolution-patches] calendar and task source deletion

[Rodrigo Moya <rodrigo ximian com>]

On Wed, 2004-03-31 at 09:18 -0500, JP Rosevear wrote:

> On Wed, 2004-03-31 at 08:54, Rodrigo Moya wrote:
> > On Tue, 2004-03-30 at 12:53 -0500, JP Rosevear wrote:
> > 
> > > On Sun, 2004-03-28 at 16:14, Rodrigo Moya wrote:
> > > > On Fri, 2004-03-26 at 14:49 -0500, William Jon McCann wrote:
> > > > 
> > > > > Hi,
> > > > > 
> > > > > Here is a patch that allows calendar and task sources to be deleted even 
> > > > > when they aren't selected/loaded.
> > > > > 
> > > > > Please let me know if this looks ok.
> > > > > 
> > > > hmm, I think it doesn't, but not your fault, but the original code. It
> > > > is written in a way that will only remove calendars that are selected,
> > > > that is:
> > > > 
> > > > cal = e_cal_model_get_client_for_uri (gnome_calendar_get_calendar_model
> > > > (priv->calendar), uri);
> > > > if (cal)
> > > > 	...
> > > > 
> > > > This will search the calendar in the view's model (which only contains
> > > > the calendars currently loaded). So, if the calendar is not loaded, the
> > > > source will be removed, but e_cal_remove won't be called for that
> > > > calendar, meaning that files won't be deleted for local calendars,
> > > > folders won't be removed for remote calendars, etc
> > > 
> > > This is no longer true, the model contains all clients that have been
> > > added to it.
> > > 
> > I thought William was changing the source selector to allow the popup
> > menu to be opened on a non-selected (so not loaded) calendar/task list.
> > Isn't that the case?
> 
> I think this patch was just allowing checked but unloaded calendars to
> be deleted.
> 
then it looks ok.

cheers