On Enj , 2004-05-06 at 13:53 -0400, William Jon McCann wrote: > >>I have taken the liberty of adding my name to the credits list. > > > > Perhaps all the names should be split up into the > > authors/translators/documentors so that the dialog is put to proper use. > > Yes, I agree. I don't know who is what, however. > > Also, you probably want to get rid of e-shell-about-box.[ch] entirely, > > and just move the code to create the about box into where > > e_shell_about_box_new () is called currently. > > That is fine with me. However, it may be good to keep the list of names > in a separate file so that e-shell-window-command.c doesn't need to be > touched when a name is added. It's not necessary really. It just means we need an extra file around to compile for a static area. Everything will get relinked anyway when you change it. It doesn't matter which of the two files it is in, in the end. It just seems extraneous to keep two extra files for a single function, just so we can keep the static array of strings out of the file where it actually gets used anyway. -- dobey
Attachment:
signature.asc
Description: This is a digitally signed message part