Re: [evolution-patches] fix for bug #67026 (compile warning that gcc now aborts on?)

[Not Zed <notzed ximian com>]

Hmm, that code should probably be removed, there's no reason to enforce ipv4 if its using addrinfo.

But since its there, other problems too, myhints should be a struct not a pointer.

The code should probably memcpy hints->myhints then set it on myhints.ai_family and then set hints=myhints.

i.e.
 if (hints != NULL) {
    memcpy(myhints, hints)
 }
 myhints.ai_family = AF_INET;
 hints = &myhints;

On Mon, 2004-10-04 at 14:17 -0400, Jeffrey Stedfast wrote:

I don't understand why gcc now aborts on this, but *shrug*

Jeff

text/plain attachment (67028.patch)

? 67028.patch
? camel-tls.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/camel/ChangeLog,v
retrieving revision 1.2251.2.12
diff -u -r1.2251.2.12 ChangeLog
--- ChangeLog	29 Sep 2004 01:57:11 -0000	1.2251.2.12
+++ ChangeLog	4 Oct 2004 18:16:04 -0000
@@ -1,3 +1,9 @@
+2004-10-04  Jeffrey Stedfast  <fejj novell com>
+
+	* camel-service.c (camel_getaddrinfo): Add a non-const cast for
+	hints when changing the ai_family member in the IPv6-disabled
+	case. Fixes bug #67028.
+
 2004-09-28  Not Zed  <NotZed Ximian com>
 
 	** See bug #66509.
Index: camel-service.c
===================================================================
RCS file: /cvs/gnome/evolution/camel/camel-service.c,v
retrieving revision 1.90.14.1
diff -u -r1.90.14.1 camel-service.c
--- camel-service.c	23 Sep 2004 04:12:29 -0000	1.90.14.1
+++ camel-service.c	4 Oct 2004 18:16:04 -0000
@@ -897,7 +897,7 @@
 		hints = &myhints;
 	}
 
-	hints->ai_family = AF_INET;
+	((struct addrinfo *) hints)->ai_family = AF_INET;
 #endif
 
 	msg = g_malloc0(sizeof(*msg));

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer