Re: [evolution-patches] evolution/cal gui patch for resource booking

[Rodrigo Moya <rodrigo novell com>]

On Fri, 2004-10-08 at 10:44 -0400, JP Rosevear wrote:
> On Fri, 2004-10-08 at 16:36 +0200, Rodrigo Moya wrote:
> > On Fri, 2004-10-08 at 18:17 +0530, Sarfraaz Ahmed wrote:
> > > Hi,
> > > 
> > > This is the new patch with the changes pointed out.
> > > 
> > > > since the "Unable to book" part is shown to the user, it should be
> > > > marked for translation.
> > > > 
> > > 
> > > > Also, the error_str is g_free'd in the wrong spot, it should be declared
> > > > and free'd inside the 'if (error->code != E_CALENDAR_STATUS_OK... block.
> > > 
> > looks good now, although you'll need gnome-i18 approval for the
> > gnome-2-8 branch
> 
> I think the fix should be more complete, we had more specific error
> messages in 1.4 iirc.
> 
what do you mean it should use, the error->message string? It is already
showing the string returned by e_cal_get_error_message.
-- 
Rodrigo Moya <rodrigo novell com>