Re: [evolution-patches] Patch to make FreeBusy calls from Evo calendar async with the main thread

[Harish Krishnaswamy <kharish novell com>]

> >
> query is not being used here at all, is it?

yes. I had just moved this code snippet to the new function in the
patch. I notice that it is the same case in the existing code too.. 
The code does not accomplish anything and probably is just incompleter.
was the intent to fetch f/b info from the urls obtained from the contact
information ?
> > @@ -325,12 +325,11 @@ clear_widgets (MeetingPage *mpage)
> > 
> here, you should be doing something with the GError, at least free it if
> e_cal_is_read_only returns something there. So, I would change this
> with:
> 
> if (!e_cal_is_read_only (...)) {
> 	read_only = TRUE;
> 	display_error_somewhere;
> 	g_error_free (error);
> }
> 
> thus, if the call fails, we disable all the widgets, as if it were a
> read only calendar.

The most common error returned is likely to occur is the
CALENDAR_BUSY_ERROR, now that the f/b calls are asynchronous. We do not
want to do anything in this case. The freeing of the error has to be
done, anyway. modifying the patch to do this.

harish