Re: [evolution-patches] Evolution calendar get_object_query optimizations

[Rodrigo Moya <rodrigo novell com>]

On Mon, 2004-10-25 at 20:06 +0530, Harish Krishnaswamy wrote:
> hi,
> 
>  The proposed patch cuts down redundant get_object_list queries to eds,
> during operations like initial loading, switching b/w views and dates
> etc. On GW accounts, this appears to solve the GUI hanging problems, at
> least in the limited scenarios we (me and chen) have tested so far. In
> some of the scenarios tested, as many as 60 queries on a GW account were
> reduced to a single query.
> 
> This may also be a solution for #59904 and the bugs resolved as its
> duplicates - though the regression has not been done yet.
> 
this is the work I am doing on the recurrences-work branch, so please,
give up on this, since I'll have it finished this week, ready to be
merged to HEAD.

Also, unfortunately, this is wrong:

> @@ -1349,10 +1350,11 @@ e_cal_view_objects_added_cb (ECalView *q
>                         rdata.query = query;
>                         rdata.model = model;
>                         rdata.icalcomp = l->data;
> -                       e_cal_generate_instances_for_object
> (rdata.client, l->data,
> -
> priv->start, priv->end,
> -
> (ECalRecurInstanceFn) add_instance_cb,
> -                                                            &rdata);
> +                       comp = e_cal_component_new ();
> +                       e_cal_component_set_icalcomponent (comp,
> l->data);
> +                       e_cal_recur_generate_instances (comp,
> priv->start, priv->end, add_instance_cb, &rdata,
> +                                       e_cal_resolve_tzid_cb,
> rdata.client, priv->zone);
> +

we need to use e_cal_generate_instances_for_object to get back any
detached recurrences, which e_cal_recur... does not return.

I'll look at the other parts of your patch to see if they are useful for
the recurrences-work-branch
-- 
Rodrigo Moya <rodrigo novell com>