Re: [evolution-patches] Patch for bugzilla bug 44876, mail and addressbook related
- From: Mengjie Yu <Meng-Jie Yu Sun COM>
- To: JP Rosevear <jpr novell com>
- Cc: patches <evolution-patches lists ximian com>
- Subject: Re: [evolution-patches] Patch for bugzilla bug 44876, mail and addressbook related
- Date: Fri, 29 Oct 2004 11:43:51 +0800
Sorry, I forgot to cc to dear all :)
Hi, JP
Thanks a lot for your review.
We need to set atk name for the entry->entry->item, however, it is not a
widget but a GnomeCanvasItem. And
we can not use gtk_widget_get_accessible to set the atk name of the
GnomeCanvasItem. Instead, we use
atj_gobject_accessible_for_object to set it.
That's why we don't use gtk_widget_get_accessibile
Regards
mengjie yu
On Thu, 2004-10-28 at 23:41, JP Rosevear wrote:
> On Tue, 2004-10-26 at 17:12 +0800, Mengjie Yu wrote:
> > Hi
> >
> > I have two patches for the bug 44876
> > http://bugzilla.ximian.com/show_bug.cgi?id=44876
> >
> > please review it.
> >
> @@ -199,6 +199,18 @@ e_select_names_manager_entry_new (ESelec
> entry->id = g_strdup (id);
>
> entry->entry = E_ENTRY (e_entry_new ());
> +
> + if (atk_get_root () != NULL) {
> + AtkObject *a11y = atk_gobject_accessible_for_object
> (entry->entry->item);
> + if (a11y != NULL) {
> + gchar *text;
> + if (pango_parse_markup (id, -1, '_', NULL,
> + &text, NULL, NULL)) {
> + atk_object_set_name (a11y, text);
> + g_free (text);
> + }
> + }
> + }
> text_model = e_select_names_text_model_new (model);
> g_object_set(entry->entry,
> "model", text_model, /* The entry takes
> ownership of the text model */
>
>
> Why doesn't this use gtk_widget_get_accessible?
>
> -JP
> --
> JP Rosevear <jpr novell com>
> Novell, Inc.
>
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]