[evolution-patches] patch for crash in evo 2.0



The bug is: http://bugzilla.ximian.com/show_bug.cgi?id=57443 (ICS import
crashes)

The reason for crashing is that libical does not support multivalued
datetime's, so it sets the error to FATAL and gets to that stupid assert
(0) which makes evolution crash.

I was looking at fixing the real problem, but seems too big a patch for
2.0, so sending this patch in the meanwhile. We probably want to add a
new bug about that unsupported multivalued datetimes, and set it to
2.0.1?
-- 
Rodrigo Moya <rodrigo novell com>
? src/libicalss/icalssyacc.output
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/libical/ChangeLog,v
retrieving revision 1.164
diff -u -p -r1.164 ChangeLog
--- ChangeLog	2 Aug 2004 11:35:45 -0000	1.164
+++ ChangeLog	3 Sep 2004 12:20:41 -0000
@@ -1,3 +1,10 @@
+2004-09-03  Rodrigo Moya <rodrigo novell com>
+
+	Fixes crash in #57443
+
+	* src/libical/icalerror.c (icalerror_set_errno): removed stupid
+	'assert' statement, to avoid crashing on fatal errors.
+
 2004-08-02  Not Zed  <NotZed Ximian com>
 
 	* src/libicalvcal/vcc.y: re-alloc when we reach the buffer length,
Index: src/libical/icalerror.c
===================================================================
RCS file: /cvs/gnome/libical/src/libical/icalerror.c,v
retrieving revision 1.13
diff -u -p -r1.13 icalerror.c
--- src/libical/icalerror.c	21 Oct 2003 18:28:28 -0000	1.13
+++ src/libical/icalerror.c	3 Sep 2004 12:20:42 -0000
@@ -97,7 +97,6 @@ void icalerror_set_errno(icalerrorenum x
        (icalerror_get_error_state(x)==ICAL_ERROR_DEFAULT && 
         icalerror_errors_are_fatal == 1 )){ 
         icalerror_warn(icalerror_strerror(x)); 
-        assert(0); 
     } 
 
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]