Re: [evolution-patches] fix for the bug 74227 [exchange calendar]
- From: chenthill <pchenthill novell com>
- To: Rodrigo Moya <rodrigo novell com>
- Cc: Sushma Rai <rsushma novell com>, patches <evolution-patches lists ximian com>
- Subject: Re: [evolution-patches] fix for the bug 74227 [exchange calendar]
- Date: Fri, 01 Apr 2005 14:47:48 +0530
Committed the fix with the NULL check. Although currently no callers are
calling it with NULL argument, it would be safe to do so.
thanks, chenthill.
On Thu, 2005-03-31 at 14:47 +0200, Rodrigo Moya wrote:
> On Thu, 2005-03-31 at 12:31 +0530, chenthill wrote:
> > Removed the check for the if (object) and changed the other callers not
> > to send NULL for this argument.
> >
>
> > - if(object)
> > - *object = e_cal_component_get_as_string (comp);
> > + *old_object = e_cal_component_get_as_string (comp);
> >
> you should still be checking for old_object not NULL, since the caller
> might pass a NULL pointer there. So:
>
> if (old_object)
> old_object = ....
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]