[evolution-patches] [addressbook]Fix for problem related to adding a contact with email address that has been added to a contact list



Hi,

 Add an email which is not there in any contact to a contact list,now if
you want to add a contact for that email id it gives you duplicate
detected.So, while checking for duplicates when adding a new contact 
emails should not be compared with existing contact lists email.
This Patch fixes the bug.

Thanks
Devashish

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1975
diff -u -p -r1.1975 ChangeLog
--- ChangeLog	9 Aug 2005 22:40:59 -0000	1.1975
+++ ChangeLog	11 Aug 2005 10:19:08 -0000
@@ -1,3 +1,12 @@
+2005-08-11  Devashish Sharma <sdevashish novell com>
+
+	* gui/widgets/eab-contact-compare.c (eab_contact_compare): Add an 
+	email which is not there in any contact to a contact list,now if 
+	you want to add a contact for that email id it gives you duplicate
+	detected.So, while checking for duplicates when adding a new contact 
+	emails should not be compared with existing contact lists email.
+	Fixed.
+
 2005-08-10  Tor Lillqvist  <tml novell com>
 
 	* importers/Makefile.am: Use privsolib instead of privlib (no
Index: eab-contact-compare.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/merging/eab-contact-compare.c,v
retrieving revision 1.8
diff -u -p -r1.8 eab-contact-compare.c
--- eab-contact-compare.c	29 Sep 2004 19:20:11 -0000	1.8
+++ eab-contact-compare.c	11 Aug 2005 10:19:35 -0000
@@ -561,7 +561,8 @@ eab_contact_compare (EContact *contact1,
 	result = EAB_CONTACT_MATCH_NONE;
 	result = combine_comparisons (result, eab_contact_compare_name      (contact1, contact2));
 	result = combine_comparisons (result, eab_contact_compare_nickname  (contact1, contact2));
-	result = combine_comparisons (result, eab_contact_compare_email     (contact1, contact2));
+	if(!(GPOINTER_TO_INT(e_contact_get(contact2, E_CONTACT_IS_LIST))))
+		result = combine_comparisons (result, eab_contact_compare_email     (contact1, contact2));
 	result = combine_comparisons (result, eab_contact_compare_address   (contact1, contact2));
 	result = combine_comparisons (result, eab_contact_compare_telephone (contact1, contact2));
 	result = combine_comparisons (result, eab_contact_compare_file_as   (contact1, contact2));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]