Re: [evolution-patches] fix for imap copy

[Not Zed <notzed ximian com>]

looks good, i added that bug with the xgwmove patch.

On Tue, 2005-02-08 at 16:25 -0500, Jeffrey Stedfast wrote:

imap's do_copy() function was always marking messages for deletion even
if the user just wanted to copy the messages to another folder. (just
discovered this while trying to create a large test imap folder).

patch attached fixes the problem

Jeff

text/plain attachment (copy-fix.patch)

? copy-fix.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/ChangeLog,v
retrieving revision 1.7
diff -u -r1.7 ChangeLog
--- ChangeLog	4 Feb 2005 03:09:22 -0000	1.7
+++ ChangeLog	8 Feb 2005 21:19:36 -0000
@@ -1,3 +1,8 @@
+2005-02-08  Jeffrey Stedfast  <fejj novell com>
+
+	* camel-imap-folder.c (do_copy): Don't always delete the original
+	messages.
+
 2005-02-04  Not Zed  <NotZed Ximian com>
 
 	* camel-imap-store.c: Revert jeff's patch.
Index: camel-imap-folder.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/camel-imap-folder.c,v
retrieving revision 1.344
diff -u -r1.344 camel-imap-folder.c
--- camel-imap-folder.c	4 Feb 2005 03:09:22 -0000	1.344
+++ camel-imap-folder.c	8 Feb 2005 21:19:36 -0000
@@ -1456,7 +1456,7 @@
 				handle_copyuid (response, source, destination);
 			camel_imap_response_free (store, response);
 
-			if (!camel_exception_is_set(ex)) {
+			if (!camel_exception_is_set(ex) && delete_originals) {
 				for (i=last;i<uid;i++)
 					camel_folder_delete_message(source, uids->pdata[i]);
 				last = uid;