Re: [evolution-patches] patch for e-vcard.c (address book)

[Hans Petter Jansson <hpj ximian com>]

On Mon, 2005-02-14 at 16:42 +0530, Sivaiah Nallagatla wrote:

> Atached patch solves the issue of losing data during 1.4 to 2.0 contact
>migration in some cases. The addresses and notes were encoded using
>quoted-printable encoding in 1.4. There were some issues in decoding
>that value during in v-card parsing in 2.0, so the when the vcard is
>written as string (e_vcard_string), it resulted invlaid utf-8 string
>causing the loss of data during migration. This issue is seen when the
>notes and addresses in 1.4 contacth has non-ascci (chars with value >
>127).

Looks good. There might be a small opportunity for improvement - instead
of running g_utf8_strlen() (which is slow) all the time, maybe the
string's length can be stored in a temporary variable.

-- 
Hans Petter Jansson | <hpj novell com>
Evolution Developer | http://hp.cl.no/