[evolution-patches] Patch for Bugzilla bugs 72285 and 71845



Hi,

When a mail containing a null From address field is Opened or Moved for
Offline View, evolution crashes. 

The attached Patch will fix this and hence solves bugs 72285 and 71845.

Thanks & Regards,
Sankar P
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/ChangeLog,v
retrieving revision 1.19
diff -u -p -r1.19 ChangeLog
--- ChangeLog	10 Feb 2005 10:51:58 -0000	1.19
+++ ChangeLog	17 Feb 2005 09:35:02 -0000
@@ -1,3 +1,10 @@
+2005-02-17  Sankar P <psankar novell com>
+
+	* camel-groupwise-folder.c:
+	  (groupwise_folder_get_message): fixed the error that crashes evolution 
+	  when mails with null From address field are viewed or moved to offline 
+	  Fixes bugs ** #72285 #71845
+
 2005-02-10  Parthasarathi Susarla <sparthasarathi novell com>
 	
 	* camel-groupwise-store.c:
Index: camel-groupwise-folder.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/camel-groupwise-folder.c,v
retrieving revision 1.24
diff -u -p -r1.24 camel-groupwise-folder.c
--- camel-groupwise-folder.c	10 Feb 2005 10:51:58 -0000	1.24
+++ camel-groupwise-folder.c	17 Feb 2005 09:35:08 -0000
@@ -246,8 +246,12 @@ groupwise_folder_get_message( CamelFolde
 		camel_mime_message_set_recipients (msg, CAMEL_RECIPIENT_TYPE_CC, cc_addr) ;
 		camel_mime_message_set_recipients (msg, CAMEL_RECIPIENT_TYPE_BCC, bcc_addr) ;
 	}
-	if (org)
-		camel_internet_address_add (from_addr,org->display_name,org->email) ;
+	if (org) {
+		camel_internet_address_add (from_addr,
+				             org->display_name ? org->display_name:"",
+					     org->email ? org->email:"" );
+		camel_mime_message_set_from (msg, from_addr) ;
+	}
 	
 	if (e_gw_item_get_reply_request (item)) {
 		char *reply_within; 
@@ -319,7 +323,6 @@ groupwise_folder_get_message( CamelFolde
 		time_t actual_time = mktime (tm) ;
 		camel_mime_message_set_date (msg, actual_time, 0) ;
 	}
-	camel_mime_message_set_from (msg, from_addr) ;
 	
 
 	/* Attachments


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]