Re: [evolution-patches] exchange settings bug patch
- From: Sushma Rai <rsushma novell com>
- To: Jeffrey Stedfast <fejj novell com>
- Cc: Not Zed <notzed ximian com>, asdf <evolution-patches lists ximian com>
- Subject: Re: [evolution-patches] exchange settings bug patch
- Date: Thu, 24 Feb 2005 11:02:27 +0530
Exchange account setup, asks for owa url and not the hostname.
Hostname is filled after the user is authenticated using owa url.
-Sushma.
On Wed, 2005-02-23 at 11:00 -0500, Jeffrey Stedfast wrote:
> right, but in what circumstances is the host being set to NULL where a
> username is appropriate?
>
> (I missed the convo so I'm lost)
>
> Jeff
>
> On Wed, 2005-02-23 at 12:23 +0800, Not Zed wrote:
> > On Tue, 2005-02-22 at 13:28 -0500, Jeffrey Stedfast wrote:
> > > I guess this looks ok... what bug is it fixing?
> >
> > One I was discussing with Sushma. Without it the host is always set
> > to NULL, and if you call camel_url_to_string with a NULL host, it
> > never outputs username or the port info, so this information will be
> > lost when it is stored on the e-account.
> >
> > Hence the last paragraph.
> >
> > > Jeff
> > >
> > > On Mon, 2005-02-21 at 17:40 +0800, Not Zed wrote:
> > > >
> > > > even though its using 'hidden host', the host is never set from NULL,
> > > > since the hidden host code never sets the value from the hidden
> > > > widget.
> > > >
> > > > this patch forces the host to "" if it is unset currently, in the
> > > > widget factory.
> > > >
> > > > note that the 'old' pointer will always be NULL for the account
> > > > editor, so this code is always run when the factory is called.
> > > >
> > > > it feels a bit hacky to me, it is unclear from rfc1808 and camel-url
> > > > whether it should actually be dropping the username part if the host
> > > > part is NULL, so i'm inclined not to change it.
> > > >
>
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]