[evolution-patches] patch for 72945 & 72946 (exchange connector)
- From: Sivaiah Nallagatla <snallagatla novell com>
- To: Evolution Patches <evolution-patches lists ximian com>
- Subject: [evolution-patches] patch for 72945 & 72946 (exchange connector)
- Date: Thu, 24 Feb 2005 18:47:09 -0800
There seems to be a mix up of e_data_book_respond calls and returing
stautus codes from backend functions. There is no reason to use
e_data_book_respond in a sync backend.
Siva
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-exchange/ChangeLog,v
retrieving revision 1.265
diff -u -p -r1.265 ChangeLog
--- ChangeLog 20 Feb 2005 06:57:46 -0000 1.265
+++ ChangeLog 24 Feb 2005 13:15:13 -0000
@@ -1,3 +1,17 @@
+2005-02-24 Sivaiah Nallagatla <snallagatla novell com>
+
+ * addressbook/e-book-backend-exchange.c
+ (e_book_backend_exchange_get_contact_list) :
+ don't use e_data_book_respond_ calls, you are
+ a sync backend. This is already done else where
+ for you.
+ Fixes #72946
+ (e_book_backend_exchange_create_contact) :
+ Don't use e_data_book_respond and don't
+ return success here. We are in offline
+ mode.
+ Fixes #72945
+
2005-02-20 Sushma Rai <rsushma novell com>
* addressbook/e-book-backend-gal.c (func_is_or_begins_with): Allowing
Index: addressbook/e-book-backend-exchange.c
===================================================================
RCS file: /cvs/gnome/evolution-exchange/addressbook/e-book-backend-exchange.c,v
retrieving revision 1.20
diff -u -p -r1.20 e-book-backend-exchange.c
--- addressbook/e-book-backend-exchange.c 25 Jan 2005 07:42:08 -0000 1.20
+++ addressbook/e-book-backend-exchange.c 24 Feb 2005 13:15:13 -0000
@@ -1269,8 +1269,7 @@ e_book_backend_exchange_create_contact (
switch (bepriv->mode) {
case GNOME_Evolution_Addressbook_MODE_LOCAL:
- e_data_book_respond_create(book, opid, GNOME_Evolution_Addressbook_RepositoryOffline, NULL);
- return GNOME_Evolution_Addressbook_Success;
+ return GNOME_Evolution_Addressbook_RepositoryOffline;
case GNOME_Evolution_Addressbook_MODE_REMOTE:
*contact = e_contact_new_from_vcard (vcard);
@@ -1752,10 +1751,8 @@ e_book_backend_exchange_get_contact_list
EVC_FORMAT_VCARD_30));
g_object_unref (offline_contacts->data);
}
- e_data_book_respond_get_contact_list (book,
- opid,
- GNOME_Evolution_Addressbook_Success,
- vcard_list);
+
+ *contacts = vcard_list;
if (temp)
g_list_free (temp);
return GNOME_Evolution_Addressbook_Success;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]