Re: [evolution-patches] Exchange : Fix for 71519

[Sarfraaz Ahmed <asarfraaz novell com>]

Thanks. Committed the patch with the changes mentioned below.

On Fri, 2005-02-25 at 15:39 +0530, Sushma Rai wrote:
> Quite a big  patch. A changelog entry would have helped in reviewing.

Yeah, shall send the Changelog for future patches. This was a long patch, probably because i had to change a method used in many places.

> exchange_create_folder(): 
> should return in case of offline. Uncomment that code.
Done
> get_message(): 
> The message retuned by find_message() is ignored.
Yeah, the proper place for doing this was in camel rather than mail, before even sending the command through the stub.
> exchange_account_open_folder():
> mode will be set to UNSUPPORTED_MODE in case 
> EXCHANGE_IS_ACCOUNT (account) condition fails in
> exchange_account_is_offline() function.
> exchange_account_open_folder() already does that check.
> so if (offline == UNSUPPORTED_MODE) becomes redundant.
Done
> scan_subtree():  
> Offline check need to be done before calling get_hrefs().
Done.
> Isn't it better to have a variable initialized to true or false, instead
> of doing the comparison (offline == whatever mode ) everytime?
Just that it saves a variable, nothing much.

Thanks
-- Sarfraaz