Re: [evolution-patches] GroupWise Calendar: Moving out of getQM

[chenthill <pchenthill novell com>]

+ value = g_strdup (valuep);      
+ key = g_strdup (keyp);

The duping is not required here. The proxy header file should be removed. The C++ style comments should be removed. The spacing should be corrected. The CURSOR_ICALID_LIMIT can be made 500 since we just get the ical ids in the response.

thanks, chenthill.

 
On Thu, 2005-07-07 at 10:40 -0600, Pasupathilingam Sankarasivasubramanian wrote:
>     Thanks for the review. I have made all the changes suggested by you. But, I update the cache with the serverUTCTime during the loginResponse. However, the place where I did this earlier was wrong and so I have moved it to where it is appropriate (connect_to_server). 
>     
>     I have also defined a new cursor limit variable CURSOR_ICALID_LIMIT . I have given a heuristical value of 200 for it. Tell me a nice value if it appears minimal.
>     
>     Thanks,
>     Sankar P
>     
>     >>> chenthill <pchenthill novell com> 07/07/05 2:08 pm >>> 
>     The patch has other changes, please send the patch with only your 
>     changes. The time stamp should be written into the file once the second 
>     getItemsResponse is received successfully. If the timestamp is 
>     corrupted, the populated flag should not be removed, which would result 
>     in getting all the items from the server and that function is not 
>     needed. 
>      
>        char *http_uri; 
>     +       int permissions, flag; 
>      
>     These variables should be declared inside the block of the code where 
>     you use it. The timestamp from loginresponse should be set in cache only 
>     once while loading all the calendar items. 
>      
>     thanks, chenthill. 
>