Re: [evolution-patches] Fix for bug 310356

[shakti <shprasad novell com>]

It seems a typo is there, /* "Cacel" button was hit */. I think it is 
'Cancel' :)

Thanks,
Shakti



Praveen Kumar wrote:

> Hi -
>
> Attached patch fixes the bug 310356. Please review.
>
> Thanks -
> Praveen.
>
>  
>
> ------------------------------------------------------------------------
>
> Index: plugins/exchange-operations/ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/plugins/exchange-operations/ChangeLog,v
> retrieving revision 1.21
> diff -u -p -r1.21 ChangeLog
> --- plugins/exchange-operations/ChangeLog	16 Jul 2005 06:48:42 -0000	1.21
> +++ plugins/exchange-operations/ChangeLog	18 Jul 2005 11:10:08 -0000
> @@ -1,3 +1,11 @@
> +2005-07-18  Praveen Kumar <kpraveen novell com>
> +
> +	* exchange-account-setup.c (btn_chpass_clicked) : Handle the case
> +	of user clicking "Cancel" button in "Change Password" dialog. Fixes
> +	bug 310356.
> +	(org_gnome_exchange_setting) : Removed the duplicate signal handler
> +	registered for "Change Password" button.
> +	
> 2005-07-16  Sarfraaz Ahmed <asarfraaz novell com>
>
> 	* exchange-ask-password.c : Removed. Is no longer being used
> Index: plugins/exchange-operations/exchange-account-setup.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/plugins/exchange-operations/exchange-account-setup.c,v
> retrieving revision 1.12
> diff -u -p -r1.12 exchange-account-setup.c
> --- plugins/exchange-operations/exchange-account-setup.c	14 Jul 2005 11:18:35 -0000	1.12
> +++ plugins/exchange-operations/exchange-account-setup.c	18 Jul 2005 11:10:08 -0000
> @@ -128,6 +128,10 @@ btn_chpass_clicked (GtkButton *button, g
> 		return;
> 	}
> 	new_password = exchange_get_new_password (old_password, TRUE);
> +	if (!new_password) {
> +		/* "Cacel" button was hit */
> +		return;
> +	}
> 	g_print ("Current password is \"%s\"\n", old_password);
>  	result = exchange_account_set_password (account, old_password, new_password);
> 	if (result != EXCHANGE_ACCOUNT_CONNECT_SUCCESS)
> @@ -329,7 +333,6 @@ org_gnome_exchange_settings(EPlugin *epl
> 	lbl_dass = (GtkLabel*) gtk_object_new (GTK_TYPE_LABEL, "label", _("Manage the delegate settings for Exchange account"), NULL);
> 	gtk_misc_set_alignment (GTK_MISC (lbl_dass), 0, 0.5);
> 	btn_dass = (GtkButton*) gtk_object_new (GTK_TYPE_BUTTON, "label", _("Delegation Assitant"));
> -	gtk_signal_connect (GTK_OBJECT (btn_chpass), "clicked", G_CALLBACK (btn_chpass_clicked), NULL);
> 	gtk_signal_connect (GTK_OBJECT (btn_dass), "clicked", G_CALLBACK (btn_dass_clicked), NULL);
> 	/* Add items to the table */
> 	gtk_table_attach_defaults (tbl_auth, GTK_WIDGET (lbl_chpass), 0, 1, 0, 1);
>  
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
>