Re: [evolution-patches] Address book - ldap backend: mutex lock for ldap handler

[Sarfraaz Ahmed <asarfraaz novell com>]

Looks good. Though i could not test it.

-- Sarfraaz

On Mon, 2005-10-03 at 15:21 +0530, Sushma Rai wrote:
> I have changes the variable name and also now using the 
> GStaticRecMutex. 
> e_book_backend_ldap_connect(), I have minimizes 
> locking and unlocking.
> I think no changes needed in e_book_backend_ldap_reconnect().
> 
> Thanks,
> Sushma.
> 
> On Tue, 2005-09-20 at 11:34 +0530, Sarfraaz Ahmed wrote:
> > Hi,
> > 
> > A few comments. Try making the name of the global varibale even more
> > unique ... something like "global_eds_ldap_lock" or some such.
> > 
> > In e_book_backend_ldap_connect, it sounds more logical to unlock the
> > lock only after the connection is complete. Instead of acquiring and
> > releasing the locks so many times in this method, how about just
> > acquiring and releasing the lock only once, i.e., at the start and end
> > of the logical completion of the connection ?.
> > 
> > Similarly with e_book_backend_ldap_reconnect too ...
> > 
> > Thanks
> > -- Sarfraaz
> > 
> > On Mon, 2005-09-19 at 10:41 +0530, Sushma Rai wrote:
> > > Hi,
> > > 
> > > There was a mistake in e_book_backend_ldap_search().
> > > I have corrected that, please consider this patch.
> > > 
> > > Thanks,
> > > Sushma.
> > > 
> > > On Tue, 2005-09-13 at 13:38 +0530, Sushma Rai wrote:
> > > > Hi,
> > > > 
> > > > Here is the patch for locking the LDAP handler while reading/writing.
> > > > This is needed, as poll_ldap calls reconnect call, which refreshes
> > > > the handler.
> > > > 
> > > > Please review.
> > > > Thanks,
> > > > Sushma.
> > > > _______________________________________________
> > > > Evolution-patches mailing list
> > > > Evolution-patches gnome org
> > > > http://mail.gnome.org/mailman/listinfo/evolution-patches
> > > _______________________________________________
> > > Evolution-patches mailing list
> > > Evolution-patches gnome org
> > > http://mail.gnome.org/mailman/listinfo/evolution-patches