Re: dialog in patch for Bug 342137 (f-spot)

[Bengt Thuree <bengt thuree com>]

On Tue, 2006-07-04 at 13:44 -0400, Bradford Powell wrote:
> Hello,
> 
> Looking over your patch for 342137, I see that you modified the 
> constructor for FileImportBackend so that it takes a GTK.Dialog as an 
> argument to pass along to the XmpTagsImporter. However, once 
> XmpTagsImporter sets its 'dialog' property, I don't see that it is ever 
> accessed. This may be either a vestige of earlier usage or planning for 
> future use, but either way, I think it may be better to remove the dialog 
> variable from XmpTagsImporter and revert the FileImportBackend back to how 
> it was for now, in the interest of keeping patches simpler.

Good catch :) Forgot about that one.

I based this patch on Gabriels GThumb tags importer
(http://bugzilla.gnome.org/show_bug.cgi?id=322366) and just kept the
parent dialog parameter. I agree with you though, that since I do not
use it, it should probably be removed.

I'll try to remove it later on today.

> I'm not sure of proper protocol, so let me know if I should have just 
> brought this up on the f-spot mailing list or added a comment to the 
> bugzilla bug.
> 

Always good to bring this up on the f-spot-list, for archiving purposes
as well as for possible more comments. Same for the bug it self.

/Bengt