Re: How do I use RawPlusJpeg?
- From: Ulf Rompe <Ulf Rompe icem com>
- To: Hubert Figuiere <hub figuiere net>
- Cc: f-spot-list gnome org
- Subject: Re: How do I use RawPlusJpeg?
- Date: Thu, 10 Jan 2008 17:20:33 +0100
On Di, 2008-01-08 at 17:12 -0500, Hubert Figuiere wrote:
> > Still feeling like a noob, I wonder if changing the code like this would
> > have any negative impact despite that the method name would be subject
> > to change:
> >
> > --- extensions/RawPlusJpeg/RawPlusJpeg.cs (revision 3530)
> > +++ extensions/RawPlusJpeg/RawPlusJpeg.cs (working copy)
> > @@ -66,7 +66,7 @@
> >
> > private static bool SamePlaceAndName (Photo p1, Photo p2)
> > {
> > - return DirectoryPath (p1) == DirectoryPath (p2) &&
> > + return (DirectoryPath (p1) == DirectoryPath (p2) || p1.Time == p2.Time) &&
> > System.IO.Path.GetFileNameWithoutExtension (p1.Name) == System.IO.Path.GetFileNameWithoutExtension (p2.Name);
> > }
> >
>
> I hope Photo.Time is determined from a safe value like the Exif
> DateTimeOriginal. I wouldn't assume the file modification date to be
> accurate, for various reasons.
If I remember correctly, it is determined from EXIF values and as a last
resort the file date. But I would have to look at the code to be sure.
Anyway, I don't see a big problem here, since it is very unlikely that
two unrelated images have the same prefix, both don't contain EXIF
information, one being a raw and the other a jpeg, and that they have
the same file creation time.
[x] ulf
--
Der Mensch ist immer noch der beste Computer. (John F. Kennedy)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]