Compilation error in bonobo-activation -- is this perhaps a bug?

[Mikael Olenfalk <mikael netgineers se>]

Hi Garnome-Guys :)


I'm wanted to test GARNOME, because I've been told a lot about it :)
Bleeding Edge Gnome2 is cool and so is GARNOME ;)

I grabbed garnome-0.18.3.tar.gz and did the following as a user:

mikael devcon-x:~$ tar xzvf Downloads/Source/garnome-0.18.3.tar.gz
mikael devcon-x:~$ cd garnome-0.18.3/meta/gnome-desktop
mikael devcon-x:~/garnome-0.18.3/meta/gnome-desktop$ make install

The build process began and did proceed successfully until it came to
bonobo-activation-activate.c. This is the output from make:


cc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I..
-DSERVER_LIBEXECDIR=\"/home/mikael/garnome/libexec\"
-DBONOBO_ACTIVATION_LOCALEDIR=\"/home/mikael/garnome//locale\"
-DORBIT2=1 -D_REENTRANT -I/home/mikael/garnome/include/glib-2.0
-I/home/mikael/garnome/lib/glib-2.0/include
-I/home/mikael/garnome/include/orbit-2.0
-I/home/mikael/garnome/include/linc-1.0 -DVERSION=\"2.1.0\"
-DG_DISABLE_DEPRECATED -I/home/mikael/garnome/include
-I/usr/X11R6/include -I/home/mikael/garnome/include -I/usr/X11R6/include
-I/home/mikael/garnome/include -I/usr/X11R6/include
-I/home/mikael/garnome/include -I/usr/X11R6/include
-I/home/mikael/garnome/include -I/usr/X11R6/include
-I/home/mikael/garnome/include -I/usr/X11R6/include
-I/home/mikael/garnome/include -I/usr/X11R6/include
-I/home/mikael/garnome/include -I/usr/X11R6/include
-I/home/mikael/garnome/include -I/usr/X11R6/include
-L/home/mikael/garnome/lib -L/usr/X11R6/lib -O2 -pipe -g
-I/home/mikael/garnome/include -I/usr/X11R6/include
-L/home/mikael/garnome/lib -L/usr/X11R6/lib -O2 -pipe -g
-I/home/mikael/garnome/include -I/usr/X11R6/include
-L/home/mikael/garnome/lib -L/usr/X11R6/lib -O2 -pipe -g
-I/home/mikael/garnome/include -I/usr/X11R6/include
-L/home/mikael/garnome/lib -L/usr/X11R6/lib -O2 -pipe -g
-I/home/mikael/garnome/include -I/usr/X11R6/include
-L/home/mikael/garnome/lib -L/usr/X11R6/lib -O2 -pipe -g
-I/home/mikael/garnome/include -I/usr/X11R6/include
-L/home/mikael/garnome/lib -L/usr/X11R6/lib -O2 -pipe -g
-I/home/mikael/garnome/include -I/usr/X11R6/include
-L/home/mikael/garnome/lib -L/usr/X11R6/lib -O2 -pipe -g
-I/home/mikael/garnome/include -I/usr/X11R6/include
-L/home/mikael/garnome/lib -L/usr/X11R6/lib -O2 -pipe -c
bonobo-activation-activate.c  -fPIC -DPIC -o
bonobo-activation-activate.lo
bonobo-activation-activate.c: In function
`bonobo_activation_init_activation_env':
bonobo-activation-activate.c:712: `LC_ALL' undeclared (first use in this
function)
bonobo-activation-activate.c:712: (Each undeclared identifier is
reported only once
bonobo-activation-activate.c:712: for each function it appears in.)
bonobo-activation-activate.c:713: `LC_COLLATE' undeclared (first use in
this function)
bonobo-activation-activate.c:714: `LC_MESSAGES' undeclared (first use in
this function)
bonobo-activation-activate.c:715: `LC_MONETARY' undeclared (first use in
this function)
bonobo-activation-activate.c:716: `LC_NUMERIC' undeclared (first use in
this function)
bonobo-activation-activate.c:717: `LC_TIME' undeclared (first use in
this function)
bonobo-activation-activate.c:729: warning: assignment makes pointer from
integer without a cast
make[10]: *** [bonobo-activation-activate.lo] Error 1
make[10]: Leaving directory
`/home/mikael/garnome-0.18.3/gnome/bonobo-activation/work/bonobo-activation-2.1.0/bonobo-activation'
make[9]: *** [all-recursive] Error 1
make[9]: Leaving directory
`/home/mikael/garnome-0.18.3/gnome/bonobo-activation/work/bonobo-activation-2.1.0'
make[8]: *** [all-recursive-am] Error 2
make[8]: Leaving directory
`/home/mikael/garnome-0.18.3/gnome/bonobo-activation/work/bonobo-activation-2.1.0'
make[7]: *** [build-work/bonobo-activation-2.1.0/Makefile] Error 2
make[7]: Leaving directory
`/home/mikael/garnome-0.18.3/gnome/bonobo-activation'make[6]: ***
[dep-../../gnome/bonobo-activation] Error 2
make[6]: Leaving directory `/home/mikael/garnome-0.18.3/gnome/libbonobo'
make[5]: *** [dep-../../gnome/libbonobo] Error 2
make[5]: Leaving directory `/home/mikael/garnome-0.18.3/gnome/gnome-vfs'
make[4]: *** [dep-../../gnome/gnome-vfs] Error 2
make[4]: Leaving directory `/home/mikael/garnome-0.18.3/gnome/libgnome'
make[3]: *** [dep-../../gnome/libgnome] Error 2
make[3]: Leaving directory
`/home/mikael/garnome-0.18.3/gnome/libbonoboui'
make[2]: *** [dep-../../gnome/libbonoboui] Error 2
make[2]: Leaving directory
`/home/mikael/garnome-0.18.3/gnome/libgnomeui'
make[1]: *** [dep-../../gnome/libgnomeui] Error 2
make[1]: Leaving directory
`/home/mikael/garnome-0.18.3/gnome/gnome-desktop'
make: *** [dep-../../gnome/gnome-desktop] Error 2
mikael devcon-x:~/garnome-0.18.3/meta/gnome-desktop$ 


I did not touch any files from the tarball before typing "make install".

I am using Debian Woody 3.0, and have installed all the packages
mentioned on the garnome page. (Without errors).

I was however able to solve the problem by adding:

#include <locale.h>

Here a simple patch. :)


--- bonobo-activation-activate.c~	Fri Oct 18 12:15:11 2002
+++ bonobo-activation-activate.c	Mon Nov 18 15:12:59 2002
@@ -36,6 +36,7 @@
 
 #include <string.h>
 #include <stdlib.h>
+#include <locale.h>
 
 static Bonobo_ActivationEnvironment activation_environment;
 



With friendly regards,
Mikael

-- 

Mikael Olenfalk
Netgineers, Sweden
<mikael at netgineers dot se>