Re: monkey-bubble development 2.11.5

["Joseph E. Sacco, PhD" <joseph_sacco comcast net>]

Robert,

Looks like a issue of "just how careful" your compiler is about checking
things.

Let's look at the code:

eggcellrenderkeys.c:592
------------------------

void
egg_cell_renderer_keys_set_accelerator (EggCellRendererKeys *keys,
                                        guint                keyval,
                                        GdkModifierType      mask)


eggcellrenderkeys.h: 73
------------------------

void             egg_cell_renderer_keys_set_accelerator (EggCellRendererKeys     *keys,
                                                         guint                    keyval,
                                                         EggVirtualModifierType   mask);


The problem is the type mismatch for "mask", which is:

        (1) clearly a coding error
        [read the author's comments in the include file]
        
        (2) easy to patch
        [see attachment]

gcc-3.3.3 let me get away with this, which is puzzling...
[an enum is an enum is an enum ???] 

-Joseph

=====================================================================================
On Fri, 2005-07-22 at 07:28 -0700, Robert Ford wrote:
> eggcellrendererkeys.c:592: error: conflicting types
> for 'egg_cell_renderer_keys_set_accelerator'
> eggcellrendererkeys.h:73: error: previous declaration
> of 'egg_cell_renderer_keys_set_accelerator' was here
> eggcellrendererkeys.c:592: error: conflicting types
> for 'egg_cell_renderer_keys_set_accelerator'
> eggcellrendererkeys.h:73: error: previous declaration
> of 'egg_cell_renderer_keys_set_accelerator' was here
> eggcellrendererkeys.c:634: error: conflicting types
> for 'egg_cell_renderer_keys_get_accelerator'
> eggcellrendererkeys.h:76: error: previous declaration
> of 'egg_cell_renderer_keys_get_accelerator' was here
> eggcellrendererkeys.c:634: error: conflicting types
> for 'egg_cell_renderer_keys_get_accelerator'
> eggcellrendererkeys.h:76: error: previous declaration
> of 'egg_cell_renderer_keys_get_accelerator' was here
> make[4]: *** [eggcellrendererkeys.o] Error 1
> 
> 
> 
> 		
> ____________________________________________________
> Start your day with Yahoo! - make it your home page 
> http://www.yahoo.com/r/hs 
> 
-- 
joseph_sacco [at] comcast [dot] net

--- ./src/ui/eggcellrendererkeys.c-	2005-07-22 11:33:25.000000000 -0400
+++ ./src/ui/eggcellrendererkeys.c	2005-07-22 11:34:27.000000000 -0400
@@ -588,7 +588,7 @@
 void
 egg_cell_renderer_keys_set_accelerator (EggCellRendererKeys *keys,
                                         guint                keyval,
-                                        GdkModifierType      mask)
+                                        EggVirtualModifierType      mask)
 {
   char *text;
   gboolean changed;
@@ -630,7 +630,7 @@
 void
 egg_cell_renderer_keys_get_accelerator (EggCellRendererKeys *keys,
                                         guint               *keyval,
-                                        GdkModifierType     *mask)
+                                        EggVirtualModifierType     *mask)
 {
   g_return_if_fail (EGG_IS_CELL_RENDERER_KEYS (keys));