Re: Foobar patch
- From: George <jirka 5z com>
- To: Chris Phelps <chicane reninet com>
- Cc: gnome-2-0-list gnome org, Havoc Pennington <hp redhat com>
- Subject: Re: Foobar patch
- Date: Wed, 12 Dec 2001 18:34:57 -0800
On Tue, Dec 11, 2001 at 04:38:46PM -0800, Chris Phelps wrote:
> /me reads manual and re-submits...
You're leaking the pixmap if you scale down. The ref behaviour is all
stupid there and the wnck_foo_foo_get_mini_icon function doesn't ref the
pixbuf, and so I made the internal default getting function also not ref it,
but it's just strange api I think. Something like pixbufs as return values
should either be 'const' or reffed. Havoc?
As to the patch, feel free to commit of course
George
--
George <jirka 5z com>
Let's not bicker and argue about who killed who.
-- Monty Python
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]