Re: diff for libgnomeprint2
- From: Darin Adler <darin bentspoon com>
- To: Lauris Kaplinski <lauris ximian com>, Jody Goldberg <jody gnome org>
- Cc: <gnome-2-0-list gnome org>
- Subject: Re: diff for libgnomeprint2
- Date: Thu, 20 Dec 2001 10:45:57 -0800
>>>> - if (!strcasecmp (name, ((GnomePrintPaper *) l->data)->name))
return
>>>> l->data;
>>>> + if (!g_strcasecmp (name, ((GnomePrintPaper *) l->data)->name))
return
I strongly suggest replacing use of the locale-specific
strcasecmp/g_strcasecmp with either g_ascii_strcasecmp or one of the
g_utf8_* family (or strcmp if you decide to make it case sensitive). I don't
think you want the comparison of these strings to depend on the current
locale setting.
-- Darin
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]